Re: fix for failing tests with gmime 2.6.19
authorJameson Graef Rollins <jrollins@finestructure.net>
Sat, 16 Nov 2013 20:16:23 +0000 (12:16 +1600)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:58:20 +0000 (09:58 -0800)
8b/9ca68837cac198ae249e240c8503a50022a82d [new file with mode: 0644]

diff --git a/8b/9ca68837cac198ae249e240c8503a50022a82d b/8b/9ca68837cac198ae249e240c8503a50022a82d
new file mode 100644 (file)
index 0000000..3a74e07
--- /dev/null
@@ -0,0 +1,130 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 430A9429E32\r
+       for <notmuch@notmuchmail.org>; Sat, 16 Nov 2013 12:16:36 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id AYfHC0HDtVna for <notmuch@notmuchmail.org>;\r
+       Sat, 16 Nov 2013 12:16:28 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1D079429E30\r
+       for <notmuch@notmuchmail.org>; Sat, 16 Nov 2013 12:16:28 -0800 (PST)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id 9C58D32802B;\r
+       Sat, 16 Nov 2013 12:16:27 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (unknown [198.129.209.202])\r
+       (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id D2D3B2E50BFF;\r
+       Sat, 16 Nov 2013 12:16:26 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 5E1EB60080; Sat, 16 Nov 2013 12:16:26 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: David Bremner <david@tethera.net>,\r
+       Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+       notmuch <notmuch@notmuchmail.org>\r
+Subject: Re: fix for failing tests with gmime 2.6.19\r
+In-Reply-To: <87iovzvyui.fsf@zancas.localnet>\r
+References: <1384100482-15453-1-git-send-email-david@tethera.net>\r
+       <52805350.70004@fifthhorseman.net> <87iovzywua.fsf@zancas.localnet>\r
+       <87iovzvyui.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.16+120~gfd733a4 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 16 Nov 2013 12:16:23 -0800\r
+Message-ID: <87iovsxfu0.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 16 Nov 2013 20:16:36 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Mon, Nov 11 2013, David Bremner <david@tethera.net> wrote:\r
+> David Bremner <david@tethera.net> writes:\r
+>\r
+>> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+>>\r
+>>>\r
+>>> Please don't introduce this cruft into the notmuch codebase.  It should\r
+>>> be fixed in gmime, not worked-around notmuch.\r
+>>>\r
+>>> I've just uploaded gmime 2.6.19-2 to unstable to address this issue.\r
+>>>\r
+>>\r
+>> Hi Daniel;\r
+>>\r
+>> Thanks a lot for that.=20\r
+>>\r
+>> What I (still) wonder about is all the people not running Debian, in the\r
+>> interval between the release of notmuch 0.17 and the next upstream\r
+>> release of gmime (and propagation to various distros).  Even on Debian,\r
+>> building on testing and backports complicates things a bit.\r
+>\r
+> An alternative approach would be to fix=20\r
+>\r
+>  NOTMUCH_SKIP_TESTS=3D"reply reply-to-sender multipart.37 from-guessing" =\r
+./notmuch-test\r
+>\r
+> to return exist status 0, and ideally to print the correct number of\r
+> tests skipped.\r
+>\r
+> I think the former just requires patching line 85 of\r
+> aggregate-results.sh.  I don't see an easy way to do the latter.\r
+>\r
+> This is arguably less crufty, or at least uses existing cruft. On the\r
+> other hand, it doesn't distinguish between a test printing an extra\r
+> space, and complete garbage.\r
+\r
+I agree with Daniel that the original series adds a whole lot of\r
+undesirable cruft to the test suite to get around one transient issue in\r
+one of the notmuch dependencies.  That doesn't seem like the best thing\r
+to do imho.  I would vote for this option instead, which doesn't modify\r
+the test suite and just skips the affected tests until the new gmime\r
+versions falls through everywhere.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.15 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJSh9KYAAoJEO00zqvie6q8UNsP/i6B5Q07UF6BXRW8BB6l+jQc\r
+a9SISjPtQf2YEqw+DMPWJAl2/tR9SP5o8yfE1qs8pSGEAa4feMFGzo8lplAliexY\r
+IOnQYSsH42gIEihrs+78FETRgp02kh3PLJ0/HfSrk8xjhTsSOMgyx9iSqHb70MGD\r
+Rk7uZgJKWDASapv1l/6LK2WxcCiZe5WznT/Ryt3UUcgmczPz7KlnxrmkwvPT4vD+\r
+lUsTsmQslVtRC8GK7uZhAzuA0Ofc/pkTJSWogXMF5kU5EXw/RzNudM7lQ6/w0BzP\r
+7l1jV0Xp+T77WdcGxSYEnm8PuugsHXjl80KemGES6dTANuvEd8bQJsnN3MqZHGlW\r
+oDY5D6b5FDCBM/JJWmVgNIvqWhi7PnPZjPZ+w5Omt2bQXsetFKGxOntgO7UbA/DQ\r
+me39jS8xrRaH6yVGdcQzCtJ+X9TgUc3NnXb9SJZhM33YqYDIFVgvXKazE2jACdNT\r
+0i9V6HoLbm9fdPJgIana+4TSPv1ixM8Bf+0Uxj0uA0AIZ+Y3Tu+Yqq9EN6P8U1eF\r
+p4lOgtDLo2K9ojq66BsXrN8FZ1VWQsN+hJyZDORyhFTucYEJQwA7P+kWIg+BKWp/\r
+Q4sPYN2cZLuLTiSTLc/PvImZmQ3r9shoavGyaQO+npkx/Jh8Tcbk/td3REIX7NvB\r
+v2yFiJoml/aTzN3/q4mE\r
+=Uc/t\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r