--- /dev/null
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 18D66431FC7\r
+ for <notmuch@notmuchmail.org>; Mon, 12 May 2014 08:34:01 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+ RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id igpEbfHCbqDp for <notmuch@notmuchmail.org>;\r
+ Mon, 12 May 2014 08:33:53 -0700 (PDT)\r
+Received: from mail-we0-f176.google.com (mail-we0-f176.google.com\r
+ [74.125.82.176]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id A92B0431FC2\r
+ for <notmuch@notmuchmail.org>; Mon, 12 May 2014 08:33:53 -0700 (PDT)\r
+Received: by mail-we0-f176.google.com with SMTP id q59so6893001wes.21\r
+ for <notmuch@notmuchmail.org>; Mon, 12 May 2014 08:33:50 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=OfCDL/bA1skE+aR+YArTZiAaEyXn6I3O6t/3iR2zJzY=;\r
+ b=G3uY8h5uQLehShUwfNqe2SKx7oXpZGu1/PHvAEr7xhxNK0jIJK87Q4nQ4UmYhS3vY0\r
+ CK3scoNjpjErK8cq+JhHogq5o5KnEvuaAzXqG+K9vjVkrvdwGVAlztqFSRdtVngpST7+\r
+ mq8lwMo8cgS27rhF3EEo2rljwP812OVwoe7A8dr6NUKS1DCmbAS3JsdLhm0c0sSz8TPG\r
+ QnzfNoLJ3TTD8/V+wfyGimsjdh5Nkadm6y/QTNcWOImizFhTUF0IgurdrnsAh12Bl9YN\r
+ mmiqIn86QvqKoL6W+E/F8WpkebcvX+x0PE4kMZ5ye+Er64pILxoIPu+DEm1Czz3UAjsi\r
+ GhHA==\r
+X-Received: by 10.180.74.132 with SMTP id t4mr16107842wiv.30.1399908830268;\r
+ Mon, 12 May 2014 08:33:50 -0700 (PDT)\r
+Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])\r
+ by mx.google.com with ESMTPSA id\r
+ kr6sm17253114wjb.16.2014.05.12.08.33.49 for <multiple recipients>\r
+ (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+ Mon, 12 May 2014 08:33:49 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 6/7] emacs: hello: add highlight newly arrived messages\r
+ option\r
+In-Reply-To: <cunlhu76quz.fsf@hotblack-desiato.hh.sledj.net>\r
+References: <1399797282-20389-1-git-send-email-markwalters1009@gmail.com>\r
+ <1399797282-20389-7-git-send-email-markwalters1009@gmail.com>\r
+ <cunlhu76quz.fsf@hotblack-desiato.hh.sledj.net>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 12 May 2014 16:33:47 +0100\r
+Message-ID: <87y4y7j9k4.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 12 May 2014 15:34:01 -0000\r
+\r
+On Mon, 12 May 2014, David Edmondson <dme@dme.org> wrote:\r
+> On Sun, May 11 2014, Mark Walters wrote:\r
+>> This adds a function that highlights searches which have newly arrived\r
+>> messages (ones which arrived since the previous refresh of\r
+>> notmuch-hello). It does that by getting a full list of matching\r
+>> message ids and checking whether any new messages have appeared. Thus\r
+>> it will be slow on large saved searches.\r
+>> ---\r
+>> emacs/notmuch-hello.el | 21 +++++++++++++++++++++\r
+>> 1 file changed, 21 insertions(+)\r
+>>\r
+>> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+>> index 28e16be..265b879 100644\r
+>> --- a/emacs/notmuch-hello.el\r
+>> +++ b/emacs/notmuch-hello.el\r
+>> @@ -96,6 +96,8 @@ (define-widget 'notmuch-saved-search-plist 'list\r
+>> (const :tag "Default (messages)" nil)\r
+>> (function-item :tag "messages/threads"\r
+>> notmuch-hello-display-count-threads-and-messages)\r
+>> + (function-item :tag "highlight newly arrived messages"\r
+>> + notmuch-hello-display-new-messages)\r
+>> function)))))\r
+>> \r
+>> (defcustom notmuch-saved-searches '((:name "inbox" :query "tag:inbox")\r
+>> @@ -507,6 +509,25 @@ (defun notmuch-hello-display-count-threads-and-messages (&rest args)\r
+>> (notmuch-hello-nice-number threads))))\r
+>> (plist-put current :count display)))\r
+>> \r
+>> +(defun notmuch-hello-display-new-messages (&rest args)\r
+>> + "Highlight saved searches which have new messages.\r
+>> +\r
+>> +New messages are ones which have appeared since the last time\r
+>> +notmuch hello was refreshed. This will be slow on large queries."\r
+>> + (let* ((current (plist-get args :current))\r
+>> + (old (plist-get args :old))\r
+>> + (query (plist-get current :query))\r
+>> + (name (plist-get current :name))\r
+>> + (new-list (notmuch-call-notmuch-sexp "search"\r
+>> + "--output=messages"\r
+>> + "--format=sexp"\r
+>> + query))\r
+>> + (old-list (plist-get old :message-list)))\r
+>> + (unless (subsetp new-list old-list :test 'equal)\r
+>> + (plist-put current :name (propertize name 'face '(:foreground "red"))))\r
+>> + (plist-put current :count (notmuch-hello-nice-number (length new-list)))\r
+>> + (plist-put current :message-list new-list)))\r
+>\r
+> I wonder if it would be better to store a hash value derived from the\r
+> message list rather than the list itself. The list could be large.\r
+\r
+My view was that the list was OK as a user would be foolish to set this\r
+for any large queries anyway (as the query itself would be too\r
+slow). Also, a hash itself wouldn't get the effect I want as I do want\r
+to be to test "subset" for the two lists (as I don't care about messages\r
+no longer matching, only new messages that do match: think inbox type\r
+things) \r
+\r
+I could store the hash of the message-id. That might save a substantial\r
+chunk on storage (eg 40 byte message if to 4byte hash or something)\r
+\r
+More generally, it is not clear to me whether we want to make it easy\r
+for a user to cause notmuch-hello to be very slow. Perhaps we need a\r
+timing for each display-function. If any one takes over 0.5s then we can\r
+report it to the user!\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+\r
+\r
+\r
+>\r
+>> +\r
+>> (defun notmuch-hello-batch-message-count (elem-plist options)\r
+>> "Update the message count for a saved search.\r
+>> \r
+>> -- \r
+>> 1.7.10.4\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff