[PATCH 01/11] lib: actually return failures from notmuch_message_tags_to_maildir_flags

diff --git a/e8/ccdb360459f270e252f7bb081d49319037c15f b/e8/ccdb360459f270e252f7bb081d49319037c15f
new file mode 100644 (file)
index 0000000..26ff2d2
--- /dev/null
+++ b/e8/ccdb360459f270e252f7bb081d49319037c15f
@@ -0,0 +1,92 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E527B431FDD\r
+       for <notmuch@notmuchmail.org>; Mon, 22 Sep 2014 02:54:57 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References"\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id bHXe8puv4m2O for <notmuch@notmuchmail.org>;\r
+       Mon, 22 Sep 2014 02:54:50 -0700 (PDT)\r
+Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com\r
+       [209.85.212.177]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 0856F431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 22 Sep 2014 02:54:49 -0700 (PDT)\r
+Received: by mail-wi0-f177.google.com with SMTP id q5so2606655wiv.4\r
+       for <notmuch@notmuchmail.org>; Mon, 22 Sep 2014 02:54:48 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\r
+       :references:in-reply-to:references;\r
+       bh=XIhOZBJgnqOmVPNAOevVVWG9yl/AJwcyVgfxbZ/aOik=;\r
+       b=FWux+zdfeMdAyWE9cio63erpwJCYaqUA9+eoPG2QFGYCw4hiRbtmlMdMdwFnYNEb1J\r
+       dnyj1Z97ie1IImaNxM92Q4tvQ507NUZYhh3ibe1hIcMHSfW7lY0Cu/WfRCj4QyPkgBVN\r
+       w+BrZRJrR+edmsvmk6+xngIsgp8qcxttHV/P6sryAg7rNnT1anzWNAn+vvWzYnzGLlyk\r
+       Etz5mEpucCnwwwWG8i/Kij9giGZDeE3lmpsFwzOYzsRe4c85+6w3xsW9GtNR3C33/39x\r
+       NCMc2o5UB/QIWvzru+WXmYbNKN86g3J/C+B1Zlu4T/B83QakHkeXmJu7Sv5tAV9lSLVH\r
+       5V8Q==\r
+X-Gm-Message-State:\r
+ ALoCoQl9Ru+LRj0JOcinrgyRdBIgRZOpuOlfURxiKkF0UkRnbCRWqKYXvbdb8K/NYGz6vi4+xW4m\r
+X-Received: by 10.180.14.104 with SMTP id o8mr14298836wic.66.1411379688830;\r
+       Mon, 22 Sep 2014 02:54:48 -0700 (PDT)\r
+Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3])\r
+       by mx.google.com with ESMTPSA id\r
+       hi4sm11686042wjb.46.2014.09.22.02.54.48 for <multiple recipients>\r
+       (version=TLSv1.1 cipher=RC4-SHA bits=128/128);\r
+       Mon, 22 Sep 2014 02:54:48 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 01/11] lib: actually return failures from\r
+       notmuch_message_tags_to_maildir_flags\r
+Date: Mon, 22 Sep 2014 11:54:52 +0200\r
+Message-Id:\r
+ <3edd34db5c4db9da9a3b0c46800126c24c334f39.1411379395.git.jani@nikula.org>\r
+X-Mailer: git-send-email 1.7.2.5\r
+In-Reply-To: <cover.1411379395.git.jani@nikula.org>\r
+References: <cover.1411379395.git.jani@nikula.org>\r
+In-Reply-To: <cover.1411379395.git.jani@nikula.org>\r
+References: <cover.1411379395.git.jani@nikula.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 22 Sep 2014 09:54:58 -0000\r
+\r
+The function takes great care to preserve the first error status it\r
+encounters, yet fails to return that status to the caller. Fix it.\r
+---\r
+ lib/message.cc |    2 +-\r
+ 1 files changed, 1 insertions(+), 1 deletions(-)\r
+\r
+diff --git a/lib/message.cc b/lib/message.cc\r
+index 68f7e68..7e82548 100644\r
+--- a/lib/message.cc\r
++++ b/lib/message.cc\r
+@@ -1497,7 +1497,7 @@ notmuch_message_tags_to_maildir_flags (notmuch_message_t *message)\r
+     talloc_free (to_set);\r
+     talloc_free (to_clear);\r
+ \r
+-    return NOTMUCH_STATUS_SUCCESS;\r
++    return status;\r
+ }\r
+ \r
+ notmuch_status_t\r
+-- \r
+1.7.2.5\r
+\r