--- /dev/null
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 16487431FD7\r
+ for <notmuch@notmuchmail.org>; Mon, 26 Aug 2013 10:58:51 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 22RC9-WSL7UC for <notmuch@notmuchmail.org>;\r
+ Mon, 26 Aug 2013 10:58:42 -0700 (PDT)\r
+Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com\r
+ [74.125.83.49]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client\r
+ certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
+ 8225F431FAF for <notmuch@notmuchmail.org>; Mon, 26 Aug 2013 10:58:42 -0700\r
+ (PDT)\r
+Received: by mail-ee0-f49.google.com with SMTP id d41so1745438eek.22\r
+ for <notmuch@notmuchmail.org>; Mon, 26 Aug 2013 10:58:41 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=google.com; s=20120113;\r
+ h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+ :user-agent:date:message-id:mime-version:content-type;\r
+ bh=h9Lxl5EUpFNUQd5yIZxwkR5ko/VEEOMcIN7wrI1YYb0=;\r
+ b=eMjwUlBwT8up43zT1tDTCyjBDxe4fNHxbxjqd2qrq5mbJeBjRxqulNkssuBb/w+TJG\r
+ a4yTTFJbjgO0c67aYq3aUz3hOpXPOo4guxqWw2bP4mL9MsGLx1kPmGofmkbxu9Y2UK60\r
+ hAbCb71NXY6ch41RgV6/u+1TJRE1Kno6XW/J0IMepa8vP1zq63cTX+gy0lQGudJ5XRaX\r
+ TqTCOD6tp1Gbh62RrJgH7b6OD83e9p49iG2CDM7L/DHSoIz6W1OwlNkgjwsMGpFor4jD\r
+ L/FUFuFoTG5xLxvEgWlbq8nWvBZGez/Ht/foOyk4U0zxOLpNOqgwJugQ3lKSbm1jeZCn\r
+ jCow==\r
+X-Gm-Message-State:\r
+ ALoCoQlhcp3CvU/e4HTrtAXNd1fBGexChmu87IFRSappf20sv+JpB310iAjxatb38BOjBuxzvgMT\r
+X-Received: by 10.14.107.68 with SMTP id n44mr28056364eeg.26.1377539921273;\r
+ Mon, 26 Aug 2013 10:58:41 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.\r
+ [88.195.111.91]) by mx.google.com with ESMTPSA id\r
+ n48sm22997399eeg.17.1969.12.31.16.00.00\r
+ (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+ Mon, 26 Aug 2013 10:58:40 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>,\r
+ Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: bugfix notmuch-mua-reply when signature is present\r
+In-Reply-To: <m238q5ycsf.fsf@guru.guru-group.fi>\r
+References:\r
+ <1375961732-14327-1-git-send-email-geoffrey.ferrari@oriel.oxon.org>\r
+ <m238qjqnt5.fsf@guru.guru-group.fi> <m238q5ycsf.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.16+32~g01f5508 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 26 Aug 2013 20:58:43 +0300\r
+Message-ID: <87bo4k2v1o.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 26 Aug 2013 17:58:51 -0000\r
+\r
+On Mon, 19 Aug 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> On Fri, Aug 09 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+>\r
+>> On Thu, Aug 08 2013, Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org> wrote:\r
+>>\r
+>>> From: "Geoffrey H. Ferrari" <geoffrey.ferrari@oriel.oxon.org>\r
+>>>\r
+>>> When composing a reply, notmuch-mua-reply tries to be smart and cite\r
+>>> the original message by inserting it before the user signature, if\r
+>>> one is present. However, the existing method of backward searching\r
+>>> from the end of the buffer to find the signature separator and then\r
+>>> moving one line up results in the original message being cited in\r
+>>> the message headers. That's because at this point the message looks\r
+>>> like this (with | representing point after searching for the\r
+>>> signature separator):\r
+>>>\r
+>>> From: xxx\r
+>>> To: xxx\r
+>>> Subject: xxx\r
+>>> --text follows this line--\r
+>>> |--\r
+>>> My fancy signature\r
+>>>\r
+>>> With this patch, a newline is opened instead, so that the orignal\r
+>>> message is cited above the signature but still in the message text.\r
+>>> ---\r
+>>\r
+>> This probably fixes #1 in id:8762auwgfl.fsf@steelpick.2x.cz\r
+>>\r
+>> ( http://mid.gmane.org/8762auwgfl.fsf@steelpick.2x.cz )\r
+>>\r
+>> ... I just noticed I have no clue how to set message signature to test\r
+>> this... ;/\r
+>\r
+> Now I tried something fancy and executed `echo foobar > ~/.signature`\r
+>\r
+> Now I get the "--\nfoobar" at the end of all emails I'm, composing -- but\r
+> I don't see any problems when replying... so I'd be interested to see\r
+> in what circumstances could I get the problem this patch solves exposed.\r
+\r
+Hi Geoffrey, we can't reproduce the issue this patch claims to fix. Care\r
+to provide more info please?\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+>\r
+>>\r
+>> Tomi\r
+>\r
+> Tomi\r
+>\r
+>\r
+>>\r
+>>\r
+>>\r
+>>> emacs/notmuch-mua.el | 2 +-\r
+>>> 1 file changed, 1 insertion(+), 1 deletion(-)\r
+>>>\r
+>>> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el\r
+>>> index 2baae5f..86f164d 100644\r
+>>> --- a/emacs/notmuch-mua.el\r
+>>> +++ b/emacs/notmuch-mua.el\r
+>>> @@ -194,7 +194,7 @@ list."\r
+>>> ;; if one is present\r
+>>> (goto-char (point-max))\r
+>>> (if (re-search-backward message-signature-separator nil t)\r
+>>> - (forward-line -1)\r
+>>> + (newline)\r
+>>> (goto-char (point-max)))\r
+>>> \r
+>>> (let ((from (plist-get original-headers :From))\r
+>>> -- \r
+>>> 1.7.10.4\r
+>>>\r
+>>> _______________________________________________\r
+>>> notmuch mailing list\r
+>>> notmuch@notmuchmail.org\r
+>>> http://notmuchmail.org/mailman/listinfo/notmuch\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff