Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures

diff --git a/7e/928fee5e5841442a6d436c22dc2c41f1927e48 b/7e/928fee5e5841442a6d436c22dc2c41f1927e48
new file mode 100644 (file)
index 0000000..1c3a6fd
--- /dev/null
+++ b/7e/928fee5e5841442a6d436c22dc2c41f1927e48
@@ -0,0 +1,82 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1B036431E82\r
+       for <notmuch@notmuchmail.org>; Sun, 17 Nov 2013 03:35:18 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Iemt5+utyXzz for <notmuch@notmuchmail.org>;\r
+       Sun, 17 Nov 2013 03:35:11 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E43C5431FC2\r
+       for <notmuch@notmuchmail.org>; Sun, 17 Nov 2013 03:35:11 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Vi0d4-0000cd-9s; Sun, 17 Nov 2013 07:35:02 -0400\r
+Received: (nullmailer pid 6354 invoked by uid 1000); Sun, 17 Nov 2013\r
+       11:34:58 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, Jani Nikula <jani@nikula.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 5/5] compact: provide user more information on\r
+       after-compaction failures\r
+In-Reply-To: <m28uwquccd.fsf@guru.guru-group.fi>\r
+References: <1384362167-12740-1-git-send-email-tomi.ollila@iki.fi>\r
+       <1384362167-12740-6-git-send-email-tomi.ollila@iki.fi>\r
+       <871u2jnkai.fsf@nikula.org> <87y54rx8sf.fsf@unb.ca>\r
+       <m28uwquccd.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.16+167~g9838fe8 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 17 Nov 2013 07:34:57 -0400\r
+Message-ID: <8738mvz2fy.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 17 Nov 2013 11:35:18 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> The log hook in it's current form is problematic as it doesn't provide\r
+> way to distinguish progress reporting from error reporting.\r
+\r
+Is this _more_ problematic than more output to stderr?\r
+\r
+>  Currently\r
+> lib/database.cc writes error messages with fprintf(stderr, ...) everywhere.\r
+\r
+Sure. But I'm trying to understand why a partial fix isn't better than\r
+nothing.  Is the argument just that the effort is wasted, or that the\r
+result is somehow less satisfactory than the status quo.\r
+\r
+> I suggest that this problem is fixed in one big sweep during 0.18\r
+> development -- the suggestion Jani pastebin'd a few days ago is\r
+> a good one and I'm willing to take part of that development...\r
+> And now take this approach of fprintf()ing (basically I would\r
+> also ask developers using the library wait for 0.18 before starting\r
+> to use the compact functionality (if ever), as the we have yet\r
+> another soname bump with changing interface coming...\r
+\r
+I guess we can mark this interface as unstable for the moment?\r
+"Asking developers not to use it" sounds pretty bad.\r
+\r
+d\r