Re: [PATCH] ruby: add bindings for `notmuch_database_get_all_tags`

diff --git a/0d/081975d063e49980a65b890fa030b5bad36dd6 b/0d/081975d063e49980a65b890fa030b5bad36dd6
new file mode 100644 (file)
index 0000000..c107650
--- /dev/null
+++ b/0d/081975d063e49980a65b890fa030b5bad36dd6
@@ -0,0 +1,75 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E374B431FC0\r
+       for <notmuch@notmuchmail.org>; Wed, 31 Dec 2014 12:11:23 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id QxYOlkT92BJ0 for <notmuch@notmuchmail.org>;\r
+       Wed, 31 Dec 2014 12:11:20 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A92F1431FCB\r
+       for <notmuch@notmuchmail.org>; Wed, 31 Dec 2014 12:11:20 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Y6Pbs-0000FH-Ci; Wed, 31 Dec 2014 16:11:12 -0400\r
+Received: (nullmailer pid 2455 invoked by uid 1000); Wed, 31 Dec 2014\r
+       20:11:06 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Ludovic LANGE <ll-notmuchmail@lange.nom.fr>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] ruby: add bindings for `notmuch_database_get_all_tags`\r
+In-Reply-To: <1416167892-15686-1-git-send-email-ll-notmuchmail@lange.nom.fr>\r
+References: <1416167892-15686-1-git-send-email-ll-notmuchmail@lange.nom.fr>\r
+User-Agent: Notmuch/0.19+7~g5d7f7a6 (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 31 Dec 2014 21:11:06 +0100\r
+Message-ID: <874msbh95x.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 31 Dec 2014 20:11:24 -0000\r
+\r
+Ludovic LANGE <ll-notmuchmail@lange.nom.fr> writes:\r
+\r
+> +    tags = notmuch_database_get_all_tags (db);\r
+> +    if (!tags)\r
+> +            rb_raise (notmuch_rb_eMemoryError, "Out of memory");\r
+\r
+Hi Ludovic;\r
+\r
+Sorry about the slow response.  It's not really your fault, but this\r
+exception is is not really correct, since there are at least two\r
+possible error conditions which get squashed into a NULL.  I have\r
+proposed a series [1] which should make it possible to tell the\r
+difference, but in the mean time I wonder if it would be better to\r
+to do \r
+\r
+rb_raise (notmuch_rb_eBaseError, "unknown notmuch error")\r
+\r
+with a comment "XXX: figure out actual error".\r
+\r
+Cheers,\r
+\r
+d\r
+\r
+[1]: id:1419788030-10567-2-git-send-email-david@tethera.net\r