Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

diff --git a/28/34638c91aa839f8e782470dad52f6c6b52aa24 b/28/34638c91aa839f8e782470dad52f6c6b52aa24
new file mode 100644 (file)
index 0000000..46fe4ef
--- /dev/null
+++ b/28/34638c91aa839f8e782470dad52f6c6b52aa24
@@ -0,0 +1,111 @@
+Return-Path: <bacuh@riseup.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0EFF0431FBD\r
+       for <notmuch@notmuchmail.org>; Sun,  6 Jul 2014 13:38:28 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.099\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       RCVD_IN_DNSWL_NONE=-0.0001, UNPARSEABLE_RELAY=0.001]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id iYPYKqSpCcnz for <notmuch@notmuchmail.org>;\r
+       Sun,  6 Jul 2014 13:38:20 -0700 (PDT)\r
+Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 17D83431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  6 Jul 2014 13:38:20 -0700 (PDT)\r
+Received: from fruiteater.riseup.net (fruiteater-pn.riseup.net [10.0.1.74])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (Client CN "*.riseup.net",\r
+       Issuer "Gandi Standard SSL CA" (not verified))\r
+       by mx1.riseup.net (Postfix) with ESMTPS id 375CA51BBF;\r
+       Sun,  6 Jul 2014 13:38:18 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=riseup.net; s=squak;\r
+       t=1404679098; bh=iplnKch84YHXNLRGW+tCPipGUbWq/PDvi5jxHeGjRlw=;\r
+       h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:\r
+       MIME-Version:Content-Type;\r
+       b=VlQ2JE00rgUxPujW0VFFta1U8cXYA+0FL4NTsd6YZjL+LFGiB9qkjsb2Nv65vtOi/\r
+       ljsS3pnisNrnFDS5cez3c7PsbgkC4/BQLwLnTBc7EbqMyFVcR8d4teflz3OReqL13p\r
+       EK16Di1+w5CKuL0lp9Wl9ktqeDgHBCvPaCa3lHzk=\r
+Received: from [127.0.0.1] (localhost [127.0.0.1])\r
+       (Authenticated sender: bacuh@fruiteater.riseup.net)\r
+       with ESMTPSA id 5B2F28F9\r
+From: Sebastian Lipp <bacuh@riseup.net>\r
+To: Karl Fogel <kfogel@red-bean.com>\r
+Subject: Re: [PATCH] emacs: add missing paren to fix defun in\r
+       notmuch-address.el.\r
+In-Reply-To: <87oax6vt4u.fsf@ktab.red-bean.com>\r
+References: <87wqsfik5l.fsf@floss.red-bean.com>\r
+       <87mwtah2hd.fsf@zancas.localnet>\r
+       <877gkeau42.fsf@floss.red-bean.com>\r
+       <m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>\r
+       <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>\r
+       <m2hajgxli5.fsf@guru.guru-group.fi>\r
+       <87vc7vgbym.fsf@zancas.localnet>\r
+       <m2ehejykb1.fsf@guru.guru-group.fi>\r
+       <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+       <87oax6vt4u.fsf@ktab.red-bean.com>\r
+User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.3.1\r
+       (i686-pc-linux-gnu)\r
+Date: Sun, 06 Jul 2014 22:37:40 +0200\r
+Message-ID:\r
+ <87bnt2dy0b.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Virus-Scanned: clamav-milter 0.98.1 at mx1\r
+X-Virus-Status: Clean\r
+Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 06 Jul 2014 20:38:28 -0000\r
+\r
+Karl Fogel <kfogel@red-bean.com> writes:\r
+> Sebastian Lipp <bacuh@riseup.net> writes:\r
+>>diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el\r
+>>index fa65cd5..ee7b169 100644\r
+>>--- a/emacs/notmuch-address.el\r
+>>+++ b/emacs/notmuch-address.el\r
+>>@@ -113,6 +113,59 @@ to know how address selection is made by default."\r
+>> (when (notmuch-address-locate-command notmuch-address-command)\r
+>>   (notmuch-address-message-insinuate))\r
+>> \r
+>>+;; functions to add sender / recipients to BBDB\r
+>>+\r
+>>+(defvar bbdb-get-addresses-headers)\r
+>\r
+> I think it's good to include an initial value (even an invalid\r
+> placeholder one, if the real initialization has not happened yet), and a\r
+> doc string.  C-h f defvar RET will say more about how to do that.\r
+\r
+I hope I got that right now. (I've got no real clue of Lisp yet because\r
+I just recently switched to emacs partly because of notmuch. :)\r
+\r
+How about\r
+\r
+    (defvar bbdb-get-addresses-headers nil\r
+      "List of Addresses to import into bbdb")\r
+\r
+?\r
+\r
+> (By the way, this isn't a user-customizeable variable, right?  If it\r
+> were, then `defcustom' would be better than `defvar'.)\r
+\r
+As far as I understand it: It's not.\r
+\r