Re: [PATCH 3/6] lib: use the backup path provided by the user, don't add anything...
authorDavid Bremner <david@tethera.net>
Sat, 2 Nov 2013 12:14:21 +0000 (09:14 +2100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:57:51 +0000 (09:57 -0800)
cc/b644256c5f4187c49c245024a57aca9e6c33eb [new file with mode: 0644]

diff --git a/cc/b644256c5f4187c49c245024a57aca9e6c33eb b/cc/b644256c5f4187c49c245024a57aca9e6c33eb
new file mode 100644 (file)
index 0000000..bd323b6
--- /dev/null
@@ -0,0 +1,68 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 45D46431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 05:14:34 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id EeFjz6CQEpJy for <notmuch@notmuchmail.org>;\r
+       Sat,  2 Nov 2013 05:14:30 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 88D71431FAE\r
+       for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 05:14:30 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Vca5w-0005hh-VR; Sat, 02 Nov 2013 09:14:24 -0300\r
+Received: (nullmailer pid 14761 invoked by uid 1000); Sat, 02 Nov 2013\r
+       12:14:21 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/6] lib: use the backup path provided by the user, don't\r
+       add anything to it\r
+In-Reply-To:\r
+ <9ee3f2334a117b0a1b88650f44432423cbe95fd7.1383315568.git.jani@nikula.org>\r
+References: <cover.1383315568.git.jani@nikula.org>\r
+       <9ee3f2334a117b0a1b88650f44432423cbe95fd7.1383315568.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.16+111~ga7964c8 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 02 Nov 2013 09:14:21 -0300\r
+Message-ID: <87li17rof6.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 02 Nov 2013 12:14:34 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> Adding another level is just useless cruft.\r
+> ---\r
+>  lib/database.cc   |   14 ++++----------\r
+>  notmuch-compact.c |    4 ++--\r
+>  2 files changed, 6 insertions(+), 12 deletions(-)\r
+\r
+The first two patches are fine, modulo my comments about documentation.\r
+I think the backup path needs to be updated in notmuch-compact.c, and\r
+possible the test updated (after applying\r
+id:1383350515-24320-1-git-send-email-david@tethera.net)\r
+\r
+d\r