Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

diff --git a/43/a3f19846fcd5969689e1046f44d25754b10b50 b/43/a3f19846fcd5969689e1046f44d25754b10b50
new file mode 100644 (file)
index 0000000..75cd4f9
--- /dev/null
+++ b/43/a3f19846fcd5969689e1046f44d25754b10b50
@@ -0,0 +1,69 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 18F6E431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 11:16:05 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 9PUTMgNXjQIn for <notmuch@notmuchmail.org>;\r
+       Tue, 28 Oct 2014 11:15:57 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id BD476431FBC\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 11:15:57 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XjBJD-0002t7-Cw; Tue, 28 Oct 2014 15:15:55 -0300\r
+Received: (nullmailer pid 30371 invoked by uid 1000); Tue, 28 Oct 2014\r
+       18:15:50 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: fix test_require_external_prereq gdb in insert test\r
+In-Reply-To: <1414518754-16344-1-git-send-email-jani@nikula.org>\r
+References: <1414518754-16344-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.18.1+131~gdd8373f (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 28 Oct 2014 19:15:50 +0100\r
+Message-ID: <87a94g2h7t.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 28 Oct 2014 18:16:05 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> You need to actually check the return value. Limit the missing deps\r
+> part to subtests requiring gdb.\r
+\r
+For me, on a system without gdb, the current version looks like\r
+\r
+T070-insert: Testing "notmuch insert"\r
+ missing prerequisites: gdb(1)\r
+ SKIP   all tests in T070-insert\r
+\r
+This seems OK to me?\r
+\r
+Of course you're right that moving it forward to only skip the gdb\r
+requiring tests is the right thing to do, and in that setting having a\r
+skipped message for all 10 skipped tests is a bit ugly. OTOHO your\r
+version doesn't give any output at all, which seems not perfect either.\r
+\r