--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 3E8BE431E62\r
+ for <notmuch@notmuchmail.org>; Tue, 20 Aug 2013 11:23:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id g3YuI9UG8Qv8 for <notmuch@notmuchmail.org>;\r
+ Tue, 20 Aug 2013 11:23:40 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 2A293431FD6\r
+ for <notmuch@notmuchmail.org>; Tue, 20 Aug 2013 11:23:39 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1VBqaT-0001uT-I2; Tue, 20 Aug 2013 19:23:28 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1VBqaT-0000CF-67; Tue, 20 Aug 2013 19:23:25 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ Istvan Marko <notmuch@kismala.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts\r
+In-Reply-To: <87fvu4fl25.fsf@servo.finestructure.net>\r
+References: <m3r4dtgz9k.fsf@zsu.kismala.com>\r
+ <87fvu4fl25.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Tue, 20 Aug 2013 19:23:24 +0100\r
+Message-ID: <87ob8ste5f.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 26e0a99910db8cbecbf5593e343a339b (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.0 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 20 Aug 2013 18:23:48 -0000\r
+\r
+\r
+Hi\r
+\r
+What does the (mis-behaving) part button say? is it [image/jpeg] or\r
+[application/octet-stream as image/jpeg] or? and what do correctly\r
+behaving part buttons say?\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+Jameson Graef Rollins <jrollins@finestructure.net> writes:\r
+\r
+> On Fri, Aug 16 2013, Istvan Marko <notmuch@kismala.com> wrote:\r
+>> When text/html parts include images as multipart/related and the\r
+>> text/plain alternative is used these images can be completely hidden\r
+>> with no easy way to access them or even find out that they are there.\r
+>>\r
+>> Make notmuch-show-insert-part-multipart/related add buttons for all\r
+>> parts, the first one visible the rest hidden.\r
+>\r
+> Hey, Istvan. Thanks so much for this patch. It seems to be addressing\r
+> the same issue I reported in id:87ob8u8l6k.fsf@servo.finestructure.net.\r
+>\r
+> However, the behavior of the part button that now appears seems to be a\r
+> bit strange. Clicking/hitting enter on the part attempts to save it\r
+> rather than open it. I wouldn't be surprised if has nothing to do with\r
+> the correctness of this patch, though. So is it possible that the\r
+> button is not inserted in the most ideal way, or is there some other\r
+> issue preventing it from behaving properly (could it have to do with the\r
+> part being "inline"?)?\r
+>\r
+> jamie.\r
+>\r
+>\r
+>> emacs/notmuch-show.el | 4 ++++\r
+>> 1 file changed, 4 insertions(+)\r
+>>\r
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+>> index 82b70ba..20844f0 100644\r
+>> --- a/emacs/notmuch-show.el\r
+>> +++ b/emacs/notmuch-show.el\r
+>> @@ -621,6 +621,10 @@ message at DEPTH in the current thread."\r
+>> \r
+>> ;; Render the primary part.\r
+>> (notmuch-show-insert-bodypart msg (car inner-parts) depth)\r
+>> + ;; Add hidden buttons for the rest\r
+>> + (mapc (lambda (inner-part)\r
+>> + (notmuch-show-insert-bodypart msg inner-part depth t))\r
+>> + (cdr inner-parts))\r
+>> \r
+>> (when notmuch-show-indent-multipart\r
+>> (indent-rigidly start (point) 1)))\r
+>> -- \r
+>> 1.8.1.4\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff