--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 23D60431FC9\r
+ for <notmuch@notmuchmail.org>; Fri, 31 Oct 2014 01:54:56 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id dEi6GgApBeg7 for <notmuch@notmuchmail.org>;\r
+ Fri, 31 Oct 2014 01:54:52 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id ED4E7431FC2\r
+ for <notmuch@notmuchmail.org>; Fri, 31 Oct 2014 01:54:51 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Xk7yi-0003WW-0T; Fri, 31 Oct 2014 08:54:42 +0000\r
+Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Xk7yh-00089K-78; Fri, 31 Oct 2014 08:54:39 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v5 0/7] notmuch search --output=sender/recipients\r
+In-Reply-To: <1414713573-21461-1-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1414713573-21461-1-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 31 Oct 2014 08:54:38 +0000\r
+Message-ID: <878ujwvctt.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 87.81.223.162\r
+X-QM-Geographic: According to ripencc,\r
+ this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 7aef95bcd98c060e85095d275d8a246a (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -0.1 points.\r
+ Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 31 Oct 2014 08:54:56 -0000\r
+\r
+On Thu, 30 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+> Hi all,\r
+>\r
+> this is v5 of the search --output=address series. It obsoletes v4\r
+> (id:1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz).\r
+>\r
+> I addresses comments from Mark and Tomi. Based on the comments to v4\r
+> and earlier versions, patches 1-4 should be ready for merging. Patch 5\r
+> is a non-controversial part of the controversial --filter-by patch and\r
+> could be probably merged after review.\r
+\r
+I have looked at Patches 1-5 and tested. These look good to me. +1\r
+\r
+My only query is in the text output: should the name part be printed as\r
+a quoted string. For example currently I get a line of the form\r
+\r
+Bloggs, Fred <fred@example.com>\r
+\r
+and I think in theory I could have a real name \r
+\r
+"Fred <stupid> Bloggs" which this would print without the quotes.\r
+\r
+For the other formats it is much less of a problem because the name and\r
+address are clearly separated.\r
+\r
+I am happy with an answer of the form "for robust parseable results use a\r
+structured format" which is what we say for search for example.\r
+\r
+I just thought I would mention it in case you thought the quoted form\r
+was more useful for consumers.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+>\r
+> Patch 6 needs at least a review and patch 7 needs more discussion.\r
+>\r
+> Changes from v4:\r
+>\r
+> - patch changed to commit in commit messages\r
+> - opt->format changed to format\r
+> - Added comments to process_* functions\r
+> - duplicite changed to duplicate\r
+> - check_duplicate changed to is_duplicate\r
+> - Deduplication was split into two commits: basic deduplication\r
+> without a command line option and configurable deduplication with\r
+> --fiter-by.\r
+>\r
+> Changes from v3:\r
+>\r
+> - `o' renamed to `opt'.\r
+> - Conversion of --output from keyword to keyword-flags is now a\r
+> separate patch.\r
+> - Structured output formats print name and address separately.\r
+> - Added test for --format=json.\r
+> - Changed --filter-by default to nameaddr. In v2, the default was\r
+> addrfold, in v3 the default was no filtering at all. I believe that\r
+> Mark's suggestion to make nameaddr the default is good trade off.\r
+> - Added new --output=count\r
+> - Minor style fixes\r
+> - Few typos fixed\r
+> - There is no way to output unfiltered (duplicite) addresses.\r
+> Hopefully, the introduction of --output=count is sufficient\r
+> replacement for this "feature".\r
+>\r
+> Cheers,\r
+> -Michal\r
+>\r
+>\r
+> Jani Nikula (1):\r
+> cli: Add support for parsing keyword-flag arguments\r
+>\r
+> Michal Sojka (6):\r
+> cli: search: Refactor passing of command line options\r
+> cli: search: Convert --output to keyword-flag argument\r
+> cli: search: Add --output={sender,recipients}\r
+> cli: search: Do not output duplicate addresses\r
+> cli: search: Add --output=count\r
+> cli: search: Add --filter-by option to configure address filtering\r
+>\r
+> command-line-arguments.c | 6 +-\r
+> command-line-arguments.h | 1 +\r
+> completion/notmuch-completion.bash | 8 +-\r
+> completion/notmuch-completion.zsh | 4 +-\r
+> doc/man1/notmuch-search.rst | 66 ++++++-\r
+> notmuch-search.c | 388 +++++++++++++++++++++++++++++--------\r
+> test/T090-search-output.sh | 137 +++++++++++++\r
+> test/T095-search-filter-by.sh | 64 ++++++\r
+> test/T410-argument-parsing.sh | 3 +-\r
+> test/arg-test.c | 9 +\r
+> 10 files changed, 604 insertions(+), 82 deletions(-)\r
+> create mode 100755 test/T095-search-filter-by.sh\r
+>\r
+> -- \r
+> 2.1.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff