Re: [PATCH] lib/message.cc: stale pointer bug (v3)

diff --git a/fd/d65ff84daae94609faffe4ad73a92218833f9e b/fd/d65ff84daae94609faffe4ad73a92218833f9e
new file mode 100644 (file)
index 0000000..bd1f423
--- /dev/null
+++ b/fd/d65ff84daae94609faffe4ad73a92218833f9e
@@ -0,0 +1,71 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9EB71431FAF\r
+       for <notmuch@notmuchmail.org>; Fri,  3 May 2013 17:43:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ftxdM4DcicoI for <notmuch@notmuchmail.org>;\r
+       Fri,  3 May 2013 17:43:55 -0700 (PDT)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 96B6D431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  3 May 2013 17:43:54 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r440SGdB030720;\r
+       Fri, 3 May 2013 21:28:16 -0300\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UYQKl-0005K5-Ii; Fri, 03 May 2013 21:28:16 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UYQKf-0004pn-Es; Fri, 03 May 2013 21:28:09 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] lib/message.cc: stale pointer bug (v3)\r
+In-Reply-To: <1367505102-12860-1-git-send-email-Vladimir.Marek@oracle.com>\r
+References: <1367505102-12860-1-git-send-email-Vladimir.Marek@oracle.com>\r
+User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 03 May 2013 21:28:09 -0300\r
+Message-ID: <878v3vvbae.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+Cc: Vladimir Marek <vlmarek@volny.cz>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 May 2013 00:44:00 -0000\r
+\r
+Vladimir.Marek@oracle.com writes:\r
+\r
+> From: Vladimir Marek <vlmarek@volny.cz>\r
+>\r
+> Xapian::TermIterator::operator* returns std::string which is destroyed\r
+> as soon as (*i).c_str() finishes. The remembered pointer 'term' then\r
+> references invalid memory.\r
+\r
+Pushed,\r
+\r
+d\r