Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections

diff --git a/cf/71f7c7b7df7677ffba0f4047247a7d6d3abb12 b/cf/71f7c7b7df7677ffba0f4047247a7d6d3abb12
new file mode 100644 (file)
index 0000000..ba68e4b
--- /dev/null
+++ b/cf/71f7c7b7df7677ffba0f4047247a7d6d3abb12
@@ -0,0 +1,123 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0BBC8431FAF\r
+       for <notmuch@notmuchmail.org>; Thu,  1 Mar 2012 14:16:21 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 6ck54C0ldzct for <notmuch@notmuchmail.org>;\r
+       Thu,  1 Mar 2012 14:16:20 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 23FDB431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  1 Mar 2012 14:16:20 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1S3EIK-0003Ik-7x; Thu, 01 Mar 2012 22:16:16 +0000\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+       helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1S3EIK-0005cx-0n; Thu, 01 Mar 2012 22:16:16 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs-hello: Do not calculate the count of the messages\r
+       in hidden sections\r
+In-Reply-To: <1329603149-6047-1-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <874nunokr5.fsf@steelpick.2x.cz>\r
+       <1329603149-6047-1-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.11.1+281~g665c451 (http://notmuchmail.org) Emacs/23.2.1\r
+       (i486-pc-linux-gnu)\r
+Date: Thu, 01 Mar 2012 22:18:04 +0000\r
+Message-ID: <87y5rk55k3.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: dc21f1850204a69a8b0c8816adf4b3ac (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 01 Mar 2012 22:16:21 -0000\r
+\r
+On Sat, 18 Feb 2012 23:12:29 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+> The result is that hello screen shows much faster when some sections are\r
+> hidden.\r
+> ---\r
+>  emacs/notmuch-hello.el |   20 ++++++++++----------\r
+>  1 files changed, 10 insertions(+), 10 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+> index aad373d..e9caade 100644\r
+> --- a/emacs/notmuch-hello.el\r
+> +++ b/emacs/notmuch-hello.el\r
+> @@ -695,16 +695,16 @@ Supports the following entries in OPTIONS as a plist:\r
+>                              (notmuch-hello-update))\r
+>                   "hide"))\r
+>      (widget-insert "\n")\r
+> -    (let (target-pos\r
+> -      (searches (apply 'notmuch-hello-query-counts query-alist options)))\r
+> -      (when (and (not is-hidden)\r
+> -           (or (not (plist-get options :hide-if-empty))\r
+> -              searches))\r
+> -    (widget-insert "\n")\r
+> -    (setq target-pos\r
+> -          (notmuch-hello-insert-buttons searches))\r
+> -    (indent-rigidly start (point) notmuch-hello-indent)\r
+> -    target-pos))))\r
+> +    (let (target-pos)\r
+> +      (when (not is-hidden)\r
+> +    (let ((searches (apply 'notmuch-hello-query-counts query-alist options)))\r
+> +      (when (or (not (plist-get options :hide-if-empty))\r
+> +                searches)\r
+> +        (widget-insert "\n")\r
+> +        (setq target-pos\r
+> +              (notmuch-hello-insert-buttons searches))\r
+> +        (indent-rigidly start (point) notmuch-hello-indent))))\r
+> +      target-pos)))\r
+>  \r
+>  (defun notmuch-hello-insert-tags-section (&optional title &rest options)\r
+>    "Insert a section displaying all tags with message counts.\r
+\r
+\r
+This looks fine to me and does speed things up when the "All tags"\r
+section is hidden (are there other sections I can hide?)\r
+\r
+Best wishes\r
+\r
+Mark\r