Re: [PATCH v3 08/10] notmuch-config: use strchr(), not index() (Solaris support)

diff --git a/49/6b57b60110695b03f27c281d331760fcef6a31 b/49/6b57b60110695b03f27c281d331760fcef6a31
new file mode 100644 (file)
index 0000000..2acb30f
--- /dev/null
+++ b/49/6b57b60110695b03f27c281d331760fcef6a31
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1D525431FD7\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Aug 2013 02:41:16 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id G7VQMqJqdSP9 for <notmuch@notmuchmail.org>;\r
+       Sat, 24 Aug 2013 02:41:11 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 060DA431FBF\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Aug 2013 02:41:11 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1VDALG-0007uE-JY; Sat, 24 Aug 2013 06:41:10 -0300\r
+Received: (nullmailer pid 2914 invoked by uid 1000); Sat, 24 Aug 2013\r
+       09:41:05 -0000\r
+From: David Bremner <bremner@unb.ca>\r
+To: Blake Jones <blakej@foo.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 08/10] notmuch-config: use strchr(), not index()\r
+       (Solaris support)\r
+In-Reply-To: <1352859005-18631-9-git-send-email-blakej@foo.net>\r
+References: <1352859005-18631-1-git-send-email-blakej@foo.net>\r
+       <1352859005-18631-9-git-send-email-blakej@foo.net>\r
+User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 24 Aug 2013 11:41:05 +0200\r
+Message-ID: <87a9k7o28e.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 24 Aug 2013 09:41:16 -0000\r
+\r
+Blake Jones <blakej@foo.net> writes:\r
+\r
+> notmuch-config.c has the only use of the function named "index()" in the\r
+> notmuch source.  Several other places use the equivalent function\r
+> "strchr()"; this patch just fixes notmuch-config.c to use strchr()\r
+> instead.  (Solaris needs to include <strings.h> to get the prototype for\r
+> index(), and notmuch-config.c was failing to include that header, so it\r
+> wasn't compiling as-is.)\r
+\r
+Pushed this patch, sorry about the delay\r
+\r
+d\r