--- /dev/null
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id AAEBC431FBD\r
+ for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 05:30:56 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id x5NihX5qfrQc for <notmuch@notmuchmail.org>;\r
+ Sat, 27 Apr 2013 05:30:55 -0700 (PDT)\r
+Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com\r
+ [209.85.217.182]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id ADF5C431FB6\r
+ for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 05:30:54 -0700 (PDT)\r
+Received: by mail-lb0-f182.google.com with SMTP id v20so4506809lbc.27\r
+ for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 05:30:53 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=google.com; s=20120113;\r
+ h=x-received:from:to:cc:subject:in-reply-to:references:user-agent\r
+ :date:message-id:mime-version:content-type:x-gm-message-state;\r
+ bh=HjRTd7Hess3a4+bCduGoXkLCyYPSsb6pAeQBA7yOcSI=;\r
+ b=THLqAhmRPYCpX8uqblzhITI61uLklGFhaYfIpE8CQuz/wbvMAFfj0S8Ldc1DlWtopk\r
+ cd2xBUmtFR8TPPb+JbY6g9bnYJp0ho9lJNA5Pnx29Eihcp/7E8w7K4jJZKCS0EnvmX/h\r
+ /brOU/2aoKNDx/lTnc4O4i8GJlEdjN8kwWjawJ3+pINy9rQKE/2WZOogmUTVyiD7AY+j\r
+ tdcVJ9eqo98IZs1kxah82YUl6FAJFSgt3k2dksJtADGWKxPQpMz5w5DnfwZulYMRwzFo\r
+ GPWCpXgJtqMiPCQk0Uix7btLeECyOT2OHDWj+g4AgvjOZgB1Y3Q532aiRKLwnQCbi4p7\r
+ sibA==\r
+X-Received: by 10.112.139.226 with SMTP id rb2mr22889383lbb.12.1367065853120; \r
+ Sat, 27 Apr 2013 05:30:53 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw2-58c376-211.dhcp.inet.fi.\r
+ [88.195.118.211])\r
+ by mx.google.com with ESMTPSA id x9sm6088526lbi.15.2013.04.27.05.30.51\r
+ for <multiple recipients>\r
+ (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+ Sat, 27 Apr 2013 05:30:52 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] don't store temporary value returned from c_str()\r
+In-Reply-To: <1366405933-17223-1-git-send-email-Vladimir.Marek@oracle.com>\r
+References: <1366405933-17223-1-git-send-email-Vladimir.Marek@oracle.com>\r
+User-Agent: Notmuch/0.15.2+70~g2eeb96a (http://notmuchmail.org) Emacs/24.2.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 27 Apr 2013 15:30:46 +0300\r
+Message-ID: <878v44qhop.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Gm-Message-State:\r
+ ALoCoQlBQJPPF/vUlE025ejIvSVzDwUhAPdFGI2QeE2mqVfYhnnZjBJf9zOKGtuKu+0SPJq27wGH\r
+Cc: Vladimir Marek <vlmarek@volny.cz>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 27 Apr 2013 12:30:57 -0000\r
+\r
+On Sat, 20 Apr 2013, Vladimir.Marek@oracle.com wrote:\r
+> From: Vladimir Marek <vlmarek@volny.cz>\r
+>\r
+> This is causing problems when compiled by Oracle Studio. Memory pointed\r
+> by (const char*)term was already changed once talloc_strdup was called.\r
+>\r
+> Signed-off-by: Vladimir Marek <vlmarek@volny.cz>\r
+> ---\r
+> lib/message.cc | 9 ++++-----\r
+> 1 files changed, 4 insertions(+), 5 deletions(-)\r
+>\r
+> diff --git a/lib/message.cc b/lib/message.cc\r
+> index 8720c1b..8d329d1 100644\r
+> --- a/lib/message.cc\r
+> +++ b/lib/message.cc\r
+> @@ -266,18 +266,17 @@ _notmuch_message_get_term (notmuch_message_t *message,\r
+> const char *prefix)\r
+> {\r
+> int prefix_len = strlen (prefix);\r
+> - const char *term = NULL;\r
+> char *value;\r
+> \r
+> i.skip_to (prefix);\r
+> \r
+> - if (i != end)\r
+> - term = (*i).c_str ();\r
+\r
+It's okay to use the result of .c_str() as long as the string object\r
+stays in scope, and none of the non-const member functions are\r
+called. Here, I think the problem is that TermIterator's overloaded\r
+operator*() returns a string object within the if block's scope, and it\r
+goes immediately out of scope. You could check this by adding\r
+\r
+ string s = *i;\r
+\r
+in function scope, and replacing (*i) with s in the if block. This might\r
+also be more obvious than the presented patch, but I think the patch is\r
+fine too.\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+> + if (i == end)\r
+> + return NULL;\r
+> \r
+> - if (!term || strncmp (term, prefix, prefix_len))\r
+> + if (strncmp ((*i).c_str(), prefix, prefix_len))\r
+> return NULL;\r
+> \r
+> - value = talloc_strdup (message, term + prefix_len);\r
+> + value = talloc_strdup (message, (*i).c_str() + prefix_len);\r
+> \r
+> #if DEBUG_DATABASE_SANITY\r
+> i++;\r
+> -- \r
+> 1.7.3.2\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff