Bug moved to the settings_object system.

diff --git a/becommands/assign.py b/becommands/assign.py
index a41bbae055156df0dee88419e8a548a85f7fcaae..2f9ff219aa0e020c97d1467cfbf2625083a9d101 100644 (file)
--- a/becommands/assign.py
+++ b/becommands/assign.py
@@ -15,7 +15,7 @@
 #    along with this program; if not, write to the Free Software
 #    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 """Assign an individual or group to fix a bug"""
-from libbe import cmdutil, bugdir
+from libbe import cmdutil, bugdir, settings_object
 __desc__ = __doc__
 
 def execute(args, test=False):
@@ -23,7 +23,7 @@ def execute(args, test=False):
     >>> import os
     >>> bd = bugdir.simple_bug_dir()
     >>> os.chdir(bd.root)
-    >>> bd.bug_from_shortname("a").assigned is None
+    >>> bd.bug_from_shortname("a").assigned is settings_object.EMPTY
     True
 
     >>> execute(["a"], test=True)
@@ -38,7 +38,7 @@ def execute(args, test=False):
 
     >>> execute(["a","none"], test=True)
     >>> bd._clear_bugs()
-    >>> bd.bug_from_shortname("a").assigned is None
+    >>> bd.bug_from_shortname("a").assigned is settings_object.EMPTY
     True
     """
     parser = get_parser()

diff --git a/becommands/new.py b/becommands/new.py
index 58fabbc9cb4f86f8c4860f49f7b509ba8cad5f52..69ff5b893ff08f419f6c9a421b3819dd42fae973 100644 (file)
--- a/becommands/new.py
+++ b/becommands/new.py
@@ -15,7 +15,7 @@
 #    along with this program; if not, write to the Free Software
 #    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 """Create a new bug"""
-from libbe import cmdutil, bugdir
+from libbe import cmdutil, bugdir, settings_object
 __desc__ = __doc__
 
 def execute(args, test=False):
@@ -35,7 +35,7 @@ def execute(args, test=False):
     True
     >>> bug.severity
     u'minor'
-    >>> bug.target == None
+    >>> bug.target == settings_object.EMPTY
     True
     """
     parser = get_parser()

diff --git a/becommands/target.py b/becommands/target.py
index d14ff069a976b5da03ee4a53efa45b603bb13de9..c83ffa7678ace1384b13599738162a7ae9083bbd 100644 (file)
--- a/becommands/target.py
+++ b/becommands/target.py
@@ -15,7 +15,7 @@
 #    along with this program; if not, write to the Free Software
 #    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 """Show or change a bug's target for fixing"""
-from libbe import cmdutil, bugdir
+from libbe import cmdutil, bugdir, settings_object
 __desc__ = __doc__
 
 def execute(args, test=False):
@@ -41,7 +41,7 @@ def execute(args, test=False):
     bd = bugdir.BugDir(from_disk=True, manipulate_encodings=not test)
     bug = bd.bug_from_shortname(args[0])
     if len(args) == 1:
-        if bug.target is None:
+        if bug.target is None or bug.target is settings_object.EMPTY:
             print "No target assigned."
         else:
             print bug.target

diff --git a/libbe/bug.py b/libbe/bug.py
index bb79d1d84971e89856db2430efa621d7d7ea2286..dfffd383aa112912c1a5f9c939b25e03fc26ebee 100644 (file)
--- a/libbe/bug.py
+++ b/libbe/bug.py
@@ -24,6 +24,7 @@ from beuuid import uuid_gen
 from properties import Property, doc_property, local_property, \
     defaulting_property, checked_property, cached_property, \
     primed_property, change_hook_property, settings_property
+import settings_object
 import mapfile
 import comment
 import utility
@@ -72,12 +73,7 @@ for i in range(len(status_values)):
     status_index[status_values[i]] = i
 
 
-# Define an invalid value for our properties, distinct from None,
-# which shows that a property has been initialized but has no value.
-EMPTY = -1
-
-
-class Bug(object):
+class Bug(settings_object.SavedSettingsObject):
     """
     >>> b = Bug()
     >>> print b.status
@@ -101,47 +97,31 @@ class Bug(object):
     >>> print b.settings["time"]
     Thu, 01 Jan 1970 00:01:00 +0000
     """
-    def _save_settings(self, old, new):
-        if self.sync_with_disk==True:
-            self.save_settings()
-    def _load_settings(self):
-        if self.sync_with_disk==True and self._settings_loaded==False:
-            self.load_settings()
-        else:
-            for property in self.settings_properties:
-                if property not in self.settings:
-                    self.settings[property] = EMPTY
-
     settings_properties = []
-    required_saved_properties = ['status','severity'] # to protect against future changes in default values
-
-    def _versioned_property(name, doc, default=None, save=_save_settings, load=_load_settings, setprops=settings_properties, allowed=None):
-        "Combine the common decorators in a single function"
-        setprops.append(name)
-        def decorator(funcs):
-            if allowed != None:
-                checked = checked_property(allowed=allowed)
-            defaulting  = defaulting_property(default=default, null=EMPTY)
-            change_hook = change_hook_property(hook=save)
-            primed      = primed_property(primer=load)
-            settings    = settings_property(name=name)
-            docp        = doc_property(doc=doc)
-            deco = defaulting(change_hook(primed(settings(docp(funcs)))))
-            if allowed != None:
-                deco = checked(deco)
-            return Property(deco)
-        return decorator
+    required_saved_properties = []
+    _prop_save_settings = settings_object.prop_save_settings
+    _prop_load_settings = settings_object.prop_load_settings
+    def _versioned_property(settings_properties=settings_properties,
+                            required_saved_properties=required_saved_properties,
+                            **kwargs):
+        if "settings_properties" not in kwargs:
+            kwargs["settings_properties"] = settings_properties
+        if "required_saved_properties" not in kwargs:
+            kwargs["required_saved_properties"]=required_saved_properties
+        return settings_object.versioned_property(**kwargs)
 
     @_versioned_property(name="severity",
                          doc="A measure of the bug's importance",
                          default="minor",
-                         allowed=severity_values)
+                         allowed=severity_values,
+                         require_save=True)
     def severity(): return {}
 
     @_versioned_property(name="status",
                          doc="The bug's current status",
                          default="open",
-                         allowed=status_values)
+                         allowed=status_values,
+                         require_save=True)
     def status(): return {}
     
     @property
@@ -206,10 +186,9 @@ class Bug(object):
 
     def __init__(self, bugdir=None, uuid=None, from_disk=False,
                  load_comments=False, summary=None):
+        settings_object.SavedSettingsObject.__init__(self)
         self.bugdir = bugdir
         self.uuid = uuid
-        self._settings_loaded = False
-        self.settings = {}
         if from_disk == True:
             self.sync_with_disk = True
         else:
@@ -224,6 +203,13 @@ class Bug(object):
     def __repr__(self):
         return "Bug(uuid=%r)" % self.uuid
 
+    def _setting_attr_string(self, setting):
+        value = getattr(self, setting)
+        if value == settings_object.EMPTY:
+            return ""
+        else:
+            return str(value)
+
     def string(self, shortlist=False, show_comments=False):
         if self.bugdir == None:
             shortname = self.uuid
@@ -239,9 +225,9 @@ class Bug(object):
                     ("Short name", shortname),
                     ("Severity", self.severity),
                     ("Status", self.status),
-                    ("Assigned", self.assigned or ""),
-                    ("Target", self.target or ""),
-                    ("Creator", self.creator or ""),
+                    ("Assigned", self._setting_attr_string("assigned")),
+                    ("Target", self._setting_attr_string("target")),
+                    ("Creator", self._setting_attr_string("creator")),
                     ("Created", timestring)]
             longest_key_len = max([len(k) for k,v in info])
             infolines = ["  %*s : %s\n" %(longest_key_len,k,v) for k,v in info]
@@ -278,12 +264,7 @@ class Bug(object):
 
     def load_settings(self):
         self.settings = mapfile.map_load(self.rcs, self.get_path("values"))
-        for property in self.settings_properties:
-            if property not in self.settings:
-                self.settings[property] = EMPTY
-            elif self.settings[property] == None:
-                self.settings[property] = EMPTY
-        self._settings_loaded = True
+        self._setup_saved_settings()
 
     def load_comments(self, load_full=True):
         if load_full == True:
@@ -300,16 +281,10 @@ class Bug(object):
 
     def save_settings(self):
         assert self.summary != None, "Can't save blank bug"
-        map = {}
-        for k,v in self.settings.items():
-            if v != None and v != EMPTY:
-                map[k] = v
-        for k in self.required_saved_properties:
-            map[k] = getattr(self, k)
-
+        
         self.rcs.mkdir(self.get_path())
         path = self.get_path("values")
-        mapfile.map_save(self.rcs, path, map)
+        mapfile.map_save(self.rcs, path, self._get_saved_settings())
         
     def save(self):
         self.save_settings()