[RFC PATCH 1/5] cli: remove leftover dir variable

diff --git a/f3/e1093bf010c89da119c7dd0a240eb1a2342cc4 b/f3/e1093bf010c89da119c7dd0a240eb1a2342cc4
new file mode 100644 (file)
index 0000000..eb268e1
--- /dev/null
+++ b/f3/e1093bf010c89da119c7dd0a240eb1a2342cc4
@@ -0,0 +1,108 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id F1D106DE02CC\r
+ for <notmuch@notmuchmail.org>; Fri, 15 Apr 2016 12:30:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References"\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.556\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.556 tagged_above=-999 required=5 tests=[AWL=0.164,\r
+  DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\r
+ RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id ufy-RZHf56MQ for <notmuch@notmuchmail.org>;\r
+ Fri, 15 Apr 2016 12:30:38 -0700 (PDT)\r
+Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com\r
+ [74.125.82.68]) by arlo.cworth.org (Postfix) with ESMTPS id B4EDA6DE00EB for\r
+ <notmuch@notmuchmail.org>; Fri, 15 Apr 2016 12:30:37 -0700 (PDT)\r
+Received: by mail-wm0-f68.google.com with SMTP id n3so8629358wmn.1\r
+ for <notmuch@notmuchmail.org>; Fri, 15 Apr 2016 12:30:37 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=nikula-org.20150623.gappssmtp.com; s=20150623;\r
+ h=from:to:cc:subject:date:message-id:in-reply-to:references\r
+ :in-reply-to:references;\r
+ bh=VpcGQ8cPP9eYznMScVWeCrY8fF+4rMvCa0ZuV43cWf0=;\r
+ b=07r+2+QiVjCZNL2meH8Rgb1UmDcqaDX17fTrUIxg7emBiu8Goz3D0tto8CpchS1FQM\r
+ rkXTkc79WnhsZilsuOc5fFrsNVbZsCXQx2OtrHv7A2ABDlfQzQhV7Yirs08L9ZjkoAxd\r
+ XL3UboGyNqc9lO1A9fJb1SCb2FWTqZ7bVfDySBwHzz9uSeRGNqPi8d9XmjCdW0Ugg/I7\r
+ kKtrB+JRMtr83NuD7oWc01VncOaocYHfCfxw+Yqwky55UIaEex4KTltoXDT866JMc5fM\r
+ 0yLcfFuZ04dKR/c+hZTtEIXDxNi5RMO/eedPObWhJV3VT3Tpb3oO11tD5fkNI4sUcxn8\r
+ HlgQ==\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\r
+ :references:in-reply-to:references;\r
+ bh=VpcGQ8cPP9eYznMScVWeCrY8fF+4rMvCa0ZuV43cWf0=;\r
+ b=JNXqURPvH8MbEfr7UJzbUzi+tleXJXad5h/pbeVIKRi6t1ysfh278eT+mTdiCYyTbK\r
+ PD0r5c1d3F7dUTU6JTPZlIpMmHGetO8KzWezPIQadgsZFRn2CSk44bzOYy1OMxbsRAS/\r
+ 0e5NWQuxlnSfP/z5yoBtFfG0lfmbGPybNSk2/AXrge85oaggXdHCbdOfWIab6+BhrQgO\r
+ FngP+Zv9ZXNmGuxoKHfbM/jZiVfxwHQbWEaOl+OX+z9Wdj+niWMMtBQ3oiITCfpzSSxU\r
+ 00uJgEFNvh71mtJb4vGKMfJU6Pn+bXTKYXn0joirZMfa7ZfUECemrjYyMoCLy/hx/gjW\r
+ Qu7w==\r
+X-Gm-Message-State:\r
+ AOPr4FUxItNYMtak/jfhwHAiy398loYiVHhoxKOur633kpG6LtFmZ0YkQtGqHekciN1FNA==\r
+X-Received: by 10.194.71.171 with SMTP id w11mr26115445wju.36.1460748636193;\r
+ Fri, 15 Apr 2016 12:30:36 -0700 (PDT)\r
+Received: from localhost (mobile-access-bcee7f-102.dhcp.inet.fi.\r
+ [188.238.127.102])\r
+ by smtp.gmail.com with ESMTPSA id r8sm50344472wjz.34.2016.04.15.12.30.35\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Fri, 15 Apr 2016 12:30:35 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: notmuch@notmuchmail.org\r
+Subject: [RFC PATCH 1/5] cli: remove leftover dir variable\r
+Date: Fri, 15 Apr 2016 22:29:15 +0300\r
+Message-Id:\r
+ <d39ffc9d1c885316a12a624f7358041e2ec448ed.1460748142.git.jani@nikula.org>\r
+X-Mailer: git-send-email 2.1.4\r
+In-Reply-To: <cover.1460748142.git.jani@nikula.org>\r
+References: <cover.1460748142.git.jani@nikula.org>\r
+In-Reply-To: <cover.1460748142.git.jani@nikula.org>\r
+References: <cover.1460748142.git.jani@nikula.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 15 Apr 2016 19:30:46 -0000\r
+\r
+No functional changes.\r
+---\r
+ notmuch-new.c | 3 ---\r
+ 1 file changed, 3 deletions(-)\r
+\r
+diff --git a/notmuch-new.c b/notmuch-new.c\r
+index 04cb5cac092a..2d975eb5b640 100644\r
+--- a/notmuch-new.c\r
++++ b/notmuch-new.c\r
+@@ -351,7 +351,6 @@ add_files (notmuch_database_t *notmuch,\r
+          const char *path,\r
+          add_files_state_t *state)\r
+ {\r
+-    DIR *dir = NULL;\r
+     struct dirent *entry = NULL;\r
+     char *next = NULL;\r
+     time_t fs_mtime, db_mtime;\r
+@@ -655,8 +654,6 @@ add_files (notmuch_database_t *notmuch,\r
+   DONE:\r
+     if (next)\r
+       talloc_free (next);\r
+-    if (dir)\r
+-      closedir (dir);\r
+     if (fs_entries) {\r
+       for (i = 0; i < num_fs_entries; i++)\r
+           free (fs_entries[i]);\r
+-- \r
+2.1.4\r
+\r