Re: [PATCH v2 07/11] lib: use the compaction backup path provided by the caller

diff --git a/b2/32f9dfabec27439b3b4583553303ee34c92b77 b/b2/32f9dfabec27439b3b4583553303ee34c92b77
new file mode 100644 (file)
index 0000000..fddc36f
--- /dev/null
+++ b/b2/32f9dfabec27439b3b4583553303ee34c92b77
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 158AB429E27\r
+       for <notmuch@notmuchmail.org>; Tue,  5 Nov 2013 02:55:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id rDaEeungo7dR for <notmuch@notmuchmail.org>;\r
+       Tue,  5 Nov 2013 02:54:53 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 5F5F8431FBF\r
+       for <notmuch@notmuchmail.org>; Tue,  5 Nov 2013 02:54:53 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1VdeHY-0000nW-Bm; Tue, 05 Nov 2013 06:54:48 -0400\r
+Received: (nullmailer pid 10563 invoked by uid 1000); Tue, 05 Nov 2013\r
+       10:54:44 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 07/11] lib: use the compaction backup path provided by\r
+       the caller\r
+In-Reply-To:\r
+ <6e8053834c8ab856c2ebab881069f18b2badcf71.1383481295.git.jani@nikula.org>\r
+References: <cover.1383481295.git.jani@nikula.org>\r
+       <6e8053834c8ab856c2ebab881069f18b2badcf71.1383481295.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.16+111~ga7964c8 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 05 Nov 2013 06:54:44 -0400\r
+Message-ID: <87ob5zqft7.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 05 Nov 2013 10:55:01 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> +    backup_path = talloc_asprintf (config, "%s/xapian.old", path);\r
+> +    if (! backup_path)\r
+> +    return 1;\r
+> +\r
+\r
+Is it intentional that no message is printed here? A random glance at\r
+notmuch-search.c suggests we usually print a message on OOM in the CLI.\r
+\r
+d\r