Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control character...

diff --git a/59/4c64c8d419d2335f6aa78c5cea790552a23389 b/59/4c64c8d419d2335f6aa78c5cea790552a23389
new file mode 100644 (file)
index 0000000..90ed6c1
--- /dev/null
+++ b/59/4c64c8d419d2335f6aa78c5cea790552a23389
@@ -0,0 +1,118 @@
+Return-Path: <flo@chaoflow.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D6A63429E20\r
+       for <notmuch@notmuchmail.org>; Sun,  8 May 2011 14:54:26 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id w1MnyWmWq0T7 for <notmuch@notmuchmail.org>;\r
+       Sun,  8 May 2011 14:54:25 -0700 (PDT)\r
+Received: from tesla.chaoflow.net (tesla.chaoflow.net [188.40.54.22])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id C9D7D431FB5\r
+       for <notmuch@notmuchmail.org>; Sun,  8 May 2011 14:54:25 -0700 (PDT)\r
+Received: from eve.chaoflow.net (ppp-93-104-187-151.dynamic.mnet-online.de\r
+       [93.104.187.151])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       (Authenticated sender: flo@chaoflow.net)\r
+       by tesla.chaoflow.net (Postfix) with ESMTPSA id 1F045C8B4;\r
+       Sun,  8 May 2011 23:54:24 +0200 (CEST)\r
+Received: by eve.chaoflow.net (Postfix, from userid 1000) id DC9762AC;\r
+       Sun, 8 May 2011 21:54:23 +0000 (Local time zone must be set--see zic\r
+       manual page)\r
+From: Florian Friesdorf <flo@chaoflow.net>\r
+To: Austin Clements <amdragon@mit.edu>\r
+Subject: Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain\r
+       control characters in notmuch-search\r
+In-Reply-To: <BANLkTi=ta-abS09Wa7=2_k7Q307u_Y4A0Q@mail.gmail.com>\r
+References: <87liyjgvyw.fsf@servo.factory.finestructure.net>\r
+       <1304889273-24560-1-git-send-email-flo@chaoflow.net>\r
+       <1304889273-24560-2-git-send-email-flo@chaoflow.net>\r
+       <BANLkTi=ta-abS09Wa7=2_k7Q307u_Y4A0Q@mail.gmail.com>\r
+User-Agent: Notmuch/0.6 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Sun, 08 May 2011 23:54:17 +0200\r
+Message-ID: <877ha06epi.fsf@eve.chaoflow.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-Virus-Scanned: clamav-milter 0.96.5 at tesla\r
+X-Virus-Status: Clean\r
+Cc: notmuch@notmuchmail.org, Andreas Amann <a.amann@ucc.ie>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 08 May 2011 21:54:27 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Sun, 8 May 2011 17:40:54 -0400, Austin Clements <amdragon@mit.edu> wrote:\r
+> Cool.  This seems very reasonable.\r
+>=20\r
+> Just some style nits: The three places where you have\r
+> "sanitize_string(", there should be a space between the function name\r
+> and the paren.\r
+\r
+fixed\r
+\r
+> Relatedly, "for(;*loop;loop++){" should be spaced out\r
+> like "for (; *loop; loop++) {".\r
+\r
+fixed\r
+\r
+> (..)=20\r
+> Also, existing code conventionally uses a variable named "local"\r
+> for function-level talloc contexts such as your ctx_quote.\r
+\r
+In notmuch-search.c there is no variable named "local", in the other\r
+functions its also named ctx_quote. Should I rename all ctx_quote to\r
+"local"?\r
+\r
+Will send style fixes after we cleared this.\r
+\r
+=2D-=20\r
+Florian Friesdorf <flo@chaoflow.net>\r
+  GPG FPR: 7A13 5EEE 1421 9FC2 108D  BAAF 38F8 99A3 0C45 F083\r
+Jabber/XMPP: flo@chaoflow.net\r
+IRC: chaoflow on freenode,ircnet,blafasel,OFTC\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v2.0.17 (GNU/Linux)\r
+\r
+iQIcBAEBAgAGBQJNxxEPAAoJEDj4maMMRfCDYg8QAK24upQa8Zv1KE2wqszPBkLo\r
+P9TBb4nqP0VUU51ZUH4uDr+yyUge0YDRkXpGOk5w3KfLqZNnncMb1IXceHUisbJB\r
+C0kjNX2c4ioeqWroyVlTTM4er8qahEnTfaSPRtrbqNuLlJera1H5I0Ux/cMmXaiW\r
+f6S4IXH6cfhyx3DuzTEvcwaiEmqcAxbuxrzEjghkmW7N9OqLFEZ8ENbE2/G4YtbD\r
+MVG+30kKd2LE4GMJKttcgcXOvdtW8mLuD8i5TY/PsZoJAdCSIgxM9l2MvgMlzkUw\r
+umubgeXq6F56jMZNvlqHUVnvHQ1SppmdSBoAIydlWzcmD8onXNukANfHz1S1cvyV\r
+DRbGa7LaCImCMgjeoGJBDwnLKR/P05fd/2v1kiq7Q3mDEkSymZTb59pTp4iyXk7h\r
+ikpX/IvbMZKFVKBV6kwKCtbp5ba37y0ChnK5DwN2o35U15Cvg1RHpX8X2Wz4lzlT\r
+9agVTvYCasxbHwF7c3dBTRq+jjPg93+2oRzh0wqz2KsUW+7DCPzX7T3v0dZoBSBY\r
+AF+fKVxYtxnzJQ6JJlhVEh5Hp3ImkiMLWDIvw3072bTI24ECXoNIJOKk9K4GVC+I\r
+lFvd69qd4ninHpUm+qNQeoRrKLQZBPs78ZhlK4EdnP8Yo7tonz6JbFDiSVczzpST\r
+eaI9DKjrnzytaCFmm99V\r
+=AA4U\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r