Re: [PATCH] lib: Simplify close and codify aborting atomic section

diff --git a/7d/ed358bcc78c22dbd63fb1b9b64aa4418388bcb b/7d/ed358bcc78c22dbd63fb1b9b64aa4418388bcb
new file mode 100644 (file)
index 0000000..b18f9cd
--- /dev/null
+++ b/7d/ed358bcc78c22dbd63fb1b9b64aa4418388bcb
@@ -0,0 +1,127 @@
+Return-Path: <wking@tremily.us>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0F6B1431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Sep 2014 12:44:21 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.1\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Gw4lKO39OW5W for <notmuch@notmuchmail.org>;\r
+       Wed, 24 Sep 2014 12:44:17 -0700 (PDT)\r
+Received: from resqmta-po-02v.sys.comcast.net (resqmta-po-02v.sys.comcast.net\r
+       [96.114.154.161])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 25DD5431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Sep 2014 12:44:17 -0700 (PDT)\r
+Received: from resomta-po-10v.sys.comcast.net ([96.114.154.234])\r
+       by resqmta-po-02v.sys.comcast.net with comcast\r
+       id v7kC1o00153iAfU017kFnz; Wed, 24 Sep 2014 19:44:15 +0000\r
+Received: from odin.tremily.us ([24.18.63.50])\r
+       by resomta-po-10v.sys.comcast.net with comcast\r
+       id v7kD1o00N152l3L017kDvK; Wed, 24 Sep 2014 19:44:15 +0000\r
+Received: by odin.tremily.us (Postfix, from userid 1000)\r
+       id 49D2D13AAFC2; Wed, 24 Sep 2014 12:44:13 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin;\r
+       t=1411587853; bh=iLJ4ws2pxI4j3fTGEnUshKIpD9JjbfMumb777C2ZsDA=;\r
+       h=Date:From:To:Cc:Subject:References:In-Reply-To;\r
+       b=E1/V5+Yf1R7UBe9FeaC0lcEVxjd4EbSPe2vyZLjiP44QuKpeO8O+8Gr99CzHpAfKo\r
+       1lCiq30UVkK/GKKnPTEU9IRenQO2G1zeF41avv7D2XassRIX1MmpgCkJpEwZL9pM9H\r
+       0nu1oI3/9KuOCHgue+5KinqRjiTlpl7jUU5GH+aA=\r
+Date: Wed, 24 Sep 2014 12:44:13 -0700\r
+From: "W. Trevor King" <wking@tremily.us>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section\r
+Message-ID: <20140924194413.GC20130@odin.tremily.us>\r
+References: <1411400615-20934-1-git-send-email-amdragon@mit.edu>\r
+       <20140922165954.GI20827@odin.tremily.us>\r
+       <20140922185050.GB7970@csail.mit.edu>\r
+       <20140922190022.GO20827@odin.tremily.us>\r
+       <87iokc28mg.fsf@maritornes.cs.unb.ca>\r
+       <20140924181844.GB20130@odin.tremily.us>\r
+       <87d2ak253z.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; micalg=pgp-sha1;\r
+       protocol="application/pgp-signature"; boundary="NU0Ex4SbNnrxsi6C"\r
+Content-Disposition: inline\r
+In-Reply-To: <87d2ak253z.fsf@maritornes.cs.unb.ca>\r
+OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;\r
+       url=http://tremily.us/pubkey.txt\r
+User-Agent: Mutt/1.5.23 (2014-03-12)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\r
+       s=q20140121; t=1411587855;\r
+       bh=iLJ4ws2pxI4j3fTGEnUshKIpD9JjbfMumb777C2ZsDA=;\r
+       h=Received:Received:Received:Date:From:To:Subject:Message-ID:\r
+       MIME-Version:Content-Type;\r
+       b=mL03OZxm4t+IMgUaruRnmHlzQzrYD90s/yJlWj0WIVHvS92u9DbavCiX5OV1Hii7K\r
+       J1/maaxZB53WHHeuVj04CUMzQM0l+ka1fohOCuRsOd2rTAakMOlAIYg2RPm4mC06xF\r
+       jG6aK+e6/x8esYMpy69Jf6XHDsH4RecfLwKHZ1xxlYJ0eo2Vp8F1orTAVpAFrTosFL\r
+       6NdMUqYgb5693eEoeey4Ly7uKj1099DE1ST9ZBcFcQGeaktiIXVyRBnNPXcrCQpsgT\r
+       qI062U0R2Yhvkw5ikU3M517kZEK103wWkkEooO2VL+G28ay75K5BHF89J63nSVwnta\r
+       WlhOwzgV3Wi1Q==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 24 Sep 2014 19:44:21 -0000\r
+\r
+\r
+--NU0Ex4SbNnrxsi6C\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Wed, Sep 24, 2014 at 09:25:20PM +0200, David Bremner wrote:\r
+> I think the fact that you have to close the notmuch database (when\r
+> not using begin/end atomic) to get a commit is surprising for many\r
+> people, so it would be nice to make that clearer somehow.\r
+\r
+It looks like Xapian is GPLv2+, so we should just be able to\r
+copy/paste/edit the line I quoted from the Xapian docs.\r
+\r
+Cheers,\r
+Trevor\r
+\r
+--=20\r
+This email may be signed or encrypted with GnuPG (http://www.gnupg.org).\r
+For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy\r
+\r
+--NU0Ex4SbNnrxsi6C\r
+Content-Type: application/pgp-signature; name="signature.asc"\r
+Content-Description: OpenPGP digital signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v2\r
+\r
+iQIcBAEBAgAGBQJUIx8LAAoJEG8/JgBt8ol8LIcP/AnDOKGu2BuzoEpcI19qyyo2\r
+ajkUaGWOF/amUJ99Ll3GLjpyBx5HduI9AwfHEqzHnbKBUl0Tnd0s6JWByWq1NtTa\r
+ejRb04aBQyL78yOl9u2YdnTvp/EttAntIU1sX9mlpuPZDBxwq7lRl8Jl1ywFuzeT\r
+48FUH/7XyYdwgXE8P2iyXGkb2bjXAhFMXSPAKFMWkn+dYYiyjIDzK94VlRXS4DeH\r
+yRU4wLQU/Ra5c/ITw0//eT670dyjIuX8+OXdND1fp5ejX160oRb/vInvHfXQiS0z\r
+FNm8aWfSt2S36aeUkeXq0VdkJh5CYJe92/Ah6DO5RBvb5QDa8l48BSKW97cYI38Y\r
+7NiVcwBT4lkxOOtdX9XG42vL9atFF4P4wC4879FNpaMGGOegXyNJsJQ6LiAH23zQ\r
+8R5JDRjkDNr0OU4aZdP+9E4hqS7afTBTLj2oP+n84aGI9Itwo51EcqMjgv9Ta9Pr\r
+GVAHvpYmEkKZG5PJjqojRRFxIa9xqS0h9m+hibYHkgYn5X39xAjTqKVmv8/RUTxb\r
+jOMsv/FxAsDD3XuPiqBGCKslFOJcs48pB4oeMttSvFvQwHTgtVzukNNITqFb8Q4P\r
+z/gCG8vlKHo+u8j+fa6fI7189ltSG3UOpu2sqeSXjlWa0+OaVrA4RgoG+Yu6mAsJ\r
+RGK0VnIAn8VTZQqRwalX\r
+=cFZi\r
+-----END PGP SIGNATURE-----\r
+\r
+--NU0Ex4SbNnrxsi6C--\r