Re: [PATCH v3 16/16] add "notmuch reindex" subcommand

diff --git a/98/147f4684d89904e2187674299db7a349de038d b/98/147f4684d89904e2187674299db7a349de038d
new file mode 100644 (file)
index 0000000..584db77
--- /dev/null
+++ b/98/147f4684d89904e2187674299db7a349de038d
@@ -0,0 +1,82 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 40C4C6DE1413\r
+ for <notmuch@notmuchmail.org>; Sun, 28 Feb 2016 07:05:41 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.035\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.035 tagged_above=-999 required=5\r
+ tests=[AWL=-0.024, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 9OhEerRQdJ3x for <notmuch@notmuchmail.org>;\r
+ Sun, 28 Feb 2016 07:05:39 -0800 (PST)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 5E42E6DE13ED\r
+ for <notmuch@notmuchmail.org>; Sun, 28 Feb 2016 07:05:39 -0800 (PST)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1aa2vK-0008V3-BM; Sun, 28 Feb 2016 10:06:18 -0500\r
+Received: (nullmailer pid 2683 invoked by uid 1000);\r
+ Sun, 28 Feb 2016 15:05:37 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v3 16/16] add "notmuch reindex" subcommand\r
+In-Reply-To: <1454272801-23623-17-git-send-email-dkg@fifthhorseman.net>\r
+References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1454272801-23623-17-git-send-email-dkg@fifthhorseman.net>\r
+User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 28 Feb 2016 11:05:37 -0400\r
+Message-ID: <87h9gs50zi.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 28 Feb 2016 15:05:41 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+> This new subcommand takes a set of search terms, and re-indexes the\r
+> list of matching messages using the supplied options.\r
+>\r
+> This can be used to index the cleartext of encrypted messages with\r
+> something like:\r
+>\r
+>  notmuch reindex --try-decrypt \\r
+>     tag:encrypted and not tag:index-decrypted\r
+\r
+I haven't reviewed this patch yet.  Before I do I'd like to discuss the\r
+issue of the apparent existing bug in thread handling that it exposes[1].\r
+\r
+Assuming that analysis is correct (and I have no reason not to believe\r
+so), the bug is in existing notmuch code and not related to this\r
+change. On the other hand, currently users have to work a bit to expose\r
+this bug, while this command would be inherently buggy (through no fault\r
+of it's own) from introduction.  With my release manager hat on, I'm not\r
+very happy with the hypothetical announcement "We have this new command,\r
+but it will break your threads". So what I'd like to understand is to\r
+what extent the reindex command, with the current notmuch codebase\r
+(i.e. no new ghost message code), is "suitable for release".\r
+\r
+One option would be to merge a version of most of the proposed changes\r
+(with some minor updates), and leave the re-index (and maybe python\r
+bindings changes) for a second series.\r
+\r
+\r
+[1]: id:871t8ko50r.fsf@alice.fifthhorseman.net\r