--- /dev/null
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id C22AC431FD0\r
+ for <notmuch@notmuchmail.org>; Thu, 23 Jun 2011 16:22:35 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id gm2-lKAZINw3 for <notmuch@notmuchmail.org>;\r
+ Thu, 23 Jun 2011 16:22:35 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0EDFD431FB6\r
+ for <notmuch@notmuchmail.org>; Thu, 23 Jun 2011 16:22:35 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 1403929A50E;\r
+ Thu, 23 Jun 2011 16:22:34 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+ id 0197C254157; Thu, 23 Jun 2011 16:22:34 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Pieter Praet <pieter@praet.org>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH] fix sum moar typos\r
+In-Reply-To: <1308600861-22684-1-git-send-email-pieter@praet.org>\r
+References: <1307202852-4398-1-git-send-email-pieter@praet.org>\r
+ <1308600861-22684-1-git-send-email-pieter@praet.org>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+ (i486-pc-linux-gnu)\r
+Date: Thu, 23 Jun 2011 16:22:27 -0700\r
+Message-ID: <8762nwdtfw.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+ micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 23 Jun 2011 23:22:35 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Mon, 20 Jun 2011 22:14:21 +0200, Pieter Praet <pieter@praet.org> wrote:\r
+> Various typo fixes in docs, docstrings, comments, etc...\r
+>=20\r
+> Signed-off-by: Pieter Praet <pieter@praet.org>\r
+\r
+Thanks for these fixes, Pieter!\r
+\r
+I've pushed these all out now. I split the original commit up into 6\r
+commits that each touch different kinds of text, (non-code text files,\r
+comments within source files, error messages within source files, etc.)\r
+\r
+The idea there is that these different kinds of text have different\r
+potential impacts on the correctness of the code. So some release\r
+manager might be willing to include one kind of change, but not another,\r
+for example.\r
+\r
+Also, it made things a bit easier to read. There were two incorrect typo\r
+fixes in the original commit which I fixed:\r
+\r
+> - "\tSeveral notmuch commands accept a comman syntax for search\n"\r
+> + "\tSeveral notmuch commands accept a command syntax for search\n"\r
+\r
+This is now "common syntax".\r
+\r
+> - # Remember stdout and stderr file descriptios and redirect test\r
+> + # Remember stdout and stderr file descriptions and redirect test\r
+\r
+This is now "file descriptors".\r
+\r
+And one change where I left the original text unchanged:\r
+\r
+> * A non-NULL return value is guaranteed to be a valid string pointer\r
+> * pointing to the characters "new/" or "cur/", (but not\r
+> - * NUL-terminated).\r
+> + * NULL-terminated).\r
+\r
+This comment uses "NULL" to describe a NULL pointer and "NUL" to\r
+describe the ASCII character '\0'. (I know that "NUL" is a really\r
+annoying historically misspelled abbreviation, but it is in standard\r
+usage I believe---see ASCII(7) for example.)\r
+\r
+Meanwhile, I was almost tempted to leave this misspelling unchanged:\r
+\r
+> - (error "%s is a file. Can't creat maildir." path))\r
+> + (error "%s is a file. Can't create maildir." path))\r
+\r
+Since that's also a classic historically misspelled abbreviation. ;-)\r
+\r
+Oh, and let me just thank you for being so thorough! There were several\r
+fixes you made that could obviously not be caught by an automated spell\r
+checker:\r
+\r
+> ---part=3Did", (David Edmonson wants to rewrite some of "notmuch show" to\r
+> +--part=3Did", (David Edmondson wants to rewrite some of "notmuch show" to\r
+...\r
+> (defun notmuch-user-other-email ()\r
+> - "Return the user.primary_email value (as a list) from the notmuch conf=\r
+iguration."\r
+> + "Return the user.other_email value (as a list) from the notmuch config=\r
+uration."\r
+...\r
+> (defcustom notmuch-after-tag-hook nil\r
+> - "Hooks that are run before tags of a message are modified.\r
+> + "Hooks that are run after tags of a message are modified.\r
+...\r
+> -The debian packaging exists in the top-level "debian" directory within\r
+> +The Debian packaging exists in the top-level "debian" directory within\r
+\r
+Those all demonstrate a particular eye for detail=E2=80=94well done! For a\r
+couple of those, I almost gave them their own commits.\r
+\r
+In passing, let me point out the most amusing typo I saw in the patch:\r
+\r
+> -} /* Appleasing Emacs */\r
+> +} /* Appeasing Emacs */\r
+\r
+I almost hate to see that go, because I like the pleasing portmanteau\r
+sound of "appleasing". Please applease me and leave this pleasing typo?\r
+\r
+Admittedly, that's not in code that's originally mine, so I can't say it\r
+wasn't intentional either.\r
+\r
+Finally, *many* of the typos and misspellings were originally mine. It's\r
+certainly embarrassing to see so many (and so many repeats). It was also\r
+embarrassing to see how many misspellings I committed while typing the\r
+commit messages, (fortunately I rebased many away).\r
+\r
+And now I'm starting to get paranoid about this message. Am I really\r
+brave enough to type words like "embarrassing", "misspelling", and\r
+"committed" here?\r
+\r
+Thanks again,\r
+\r
+=2DCarl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk4DyrMACgkQ6JDdNq8qSWiqKQCfdc3+sNLZ54TX/WQo4l/GQC+o\r
+jXIAn1Oiz1iIvRKgPVd0c50xySBjusmX\r
+=Y2KO\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r
projects / notmuch-archives.git / commitdiff