Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro

diff --git a/9a/7d74407d68c3089f451c1f7b995098a5bc3fc9 b/9a/7d74407d68c3089f451c1f7b995098a5bc3fc9
new file mode 100644 (file)
index 0000000..e15d74d
--- /dev/null
+++ b/9a/7d74407d68c3089f451c1f7b995098a5bc3fc9
@@ -0,0 +1,84 @@
+Return-Path: <teythoon@jade-hamburg.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 9CA646DE01F7\r
+ for <notmuch@notmuchmail.org>; Tue,  1 Mar 2016 08:46:24 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.001\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.001 tagged_above=-999 required=5\r
+ tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001,\r
+ RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id B8nNiF5T5Lf0 for <notmuch@notmuchmail.org>;\r
+ Tue,  1 Mar 2016 08:46:22 -0800 (PST)\r
+Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 6E5736DE00DF\r
+ for <notmuch@notmuchmail.org>; Tue,  1 Mar 2016 08:46:22 -0800 (PST)\r
+Received: from thinkbox (p4FD27A8D.dip0.t-ipconnect.de [79.210.122.141])\r
+ (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\r
+ (No client certificate requested)\r
+ by mail.cryptobitch.de (Postfix) with ESMTPSA id 0A83D8F94ED;\r
+ Tue,  1 Mar 2016 17:46:19 +0100 (CET)\r
+Received: from teythoon by thinkbox with local (Exim 4.84)\r
+ (envelope-from <teythoon@thinkbox.jade-hamburg.de>)\r
+ id 1aanRC-0006ce-5o; Tue, 01 Mar 2016 17:46:18 +0100\r
+Content-Type: text/plain; charset="utf-8"\r
+MIME-Version: 1.0\r
+Content-Transfer-Encoding: quoted-printable\r
+To: Jani Nikula <jani@nikula.org>, "Tomi Ollila" <tomi.ollila@iki.fi>,\r
+ notmuch@notmuchmail.org\r
+From: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+In-Reply-To: <87k2nxh3pn.fsf@nikula.org>\r
+Cc: tomi.ollila@iki.fi\r
+References: <1439303834-27030-1-git-send-email-tomi.ollila@iki.fi>\r
+ <87k2nxh3pn.fsf@nikula.org>\r
+Message-ID: <20160301164618.4486.11370@thinkbox.jade-hamburg.de>\r
+User-Agent: alot/0.3.8.dev\r
+Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro\r
+Date: Tue, 01 Mar 2016 17:46:18 +0100\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 01 Mar 2016 16:46:24 -0000\r
+\r
+Quoting Jani Nikula (2015-12-29 12:52:20)\r
+> > __has_extension() replacement was modeled after __has_attribute()\r
+> > definition in compat/function-attributes.h. Thanks Justus.\r
+\r
+Hum, I didn't even recall doing that.\r
+\r
+> > +/* clang provides this macro to test for support for language\r
+> > + * extensions. If it isn't defined, this provides a compatibility\r
+> > + * macro for other compilers.\r
+> > + */\r
+> > +#ifndef __has_extension\r
+> > +#define __has_extension(x) 0\r
+> > +#endif\r
+> =\r
+\r
+> This file is included by the users of the library, and thus this\r
+> definition leaks to our users. It might cause problems if the users have\r
+> different expectations for handling ifndef __has_extension. I don't\r
+> think we should define things outside of our namespace in notmuch.h.\r
+\r
+Indeed, even more so since the __ namespace is reserved.  But that\r
+should be easy to fix, right?  Simply pick a less problematic name for\r
+the new macro.\r
+\r
+I'd love to see this issue fixed.\r
+\r
+Cheers,\r
+Justus\r