Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results
authorJani Nikula <jani@nikula.org>
Wed, 2 Nov 2011 09:27:41 +0000 (09:27 +0000)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:39:58 +0000 (09:39 -0800)
c5/bad8ec97d3286ffa8f978f26b51da4a787765c [new file with mode: 0644]

diff --git a/c5/bad8ec97d3286ffa8f978f26b51da4a787765c b/c5/bad8ec97d3286ffa8f978f26b51da4a787765c
new file mode 100644 (file)
index 0000000..c4b39b3
--- /dev/null
@@ -0,0 +1,79 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 93617431FD0\r
+       for <notmuch@notmuchmail.org>; Wed,  2 Nov 2011 02:27:49 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id bHJrE9nlgycI for <notmuch@notmuchmail.org>;\r
+       Wed,  2 Nov 2011 02:27:49 -0700 (PDT)\r
+Received: from mail-vw0-f53.google.com (mail-vw0-f53.google.com\r
+       [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id F316D431FB6\r
+       for <notmuch@notmuchmail.org>; Wed,  2 Nov 2011 02:27:48 -0700 (PDT)\r
+Received: by vws19 with SMTP id 19so3113057vws.26\r
+       for <notmuch@notmuchmail.org>; Wed, 02 Nov 2011 02:27:47 -0700 (PDT)\r
+Received: by 10.52.27.208 with SMTP id v16mr3758205vdg.22.1320226067104;\r
+       Wed, 02 Nov 2011 02:27:47 -0700 (PDT)\r
+Received: from localhost (nikula.org. [92.243.24.172])\r
+       by mx.google.com with ESMTPS id il5sm2554890vdb.7.2011.11.02.02.27.43\r
+       (version=SSLv3 cipher=OTHER); Wed, 02 Nov 2011 02:27:44 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in\r
+       search results\r
+In-Reply-To: <87zkgg6n3z.fsf@zancas.localnet>\r
+References: <cover.1320093940.git.jani@nikula.org>\r
+       <87zkgg6n3z.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.5-232-g917e874 (http://notmuchmail.org) Emacs/23.1.1\r
+       (i686-pc-linux-gnu)\r
+Date: Wed, 02 Nov 2011 09:27:41 +0000\r
+Message-ID: <87aa8ekh6a.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 02 Nov 2011 09:27:49 -0000\r
+\r
+On Tue, 01 Nov 2011 09:30:56 -0300, David Bremner <david@tethera.net> wrote:\r
+> Is just because it add a function to the library that you think this\r
+> might be problematic?  I don't think we are super-dogmatic about the\r
+> library never growing.  When notmuch started, there were no bindings, so\r
+> in retrospect maybe more functionality went into the CLI than might\r
+> happen if we started from scratch. If I remember Carl's statement\r
+> correctly, one rule is that stuff in the library should not require\r
+> configuration.\r
+\r
+Hi, thanks, that's encouraging. It's mostly that, based on past\r
+experience, I'm hesitant about extending a library interface. Once you\r
+get users, you have to live with it. So you want to get it right.\r
+\r
+Having said that, I think in this v2 of the set, the library interface\r
+for notmuch_query_count_threads() is sane and complimentary to the\r
+existing notmuch_query_count_messages(). (Also quoting IRC: "<amdragon>\r
+j4ni: Yes, the interface seems totally reasonable.") Later on, someone\r
+might come up with a better implementation, but for now it's already\r
+much better than having to iterate and construct the threads.\r
+\r
+I'll prepare a v3 with some tests and polish.\r
+\r
+BR,\r
+Jani.\r