Re: [PATCH v3 10/10] cli: address: Add --filter-by option to configure address filtering

diff --git a/cf/f13aff3536790f94106b402fc25501b5d69d02 b/cf/f13aff3536790f94106b402fc25501b5d69d02
new file mode 100644 (file)
index 0000000..9ac59cd
--- /dev/null
+++ b/cf/f13aff3536790f94106b402fc25501b5d69d02
@@ -0,0 +1,84 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 40CE8431FC7\r
+       for <notmuch@notmuchmail.org>; Thu,  1 Jan 2015 04:04:23 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5YcNRz8pn8OB for <notmuch@notmuchmail.org>;\r
+       Thu,  1 Jan 2015 04:04:20 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id EC7A9431FC0\r
+       for <notmuch@notmuchmail.org>; Thu,  1 Jan 2015 04:04:19 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 5F802100051;\r
+       Thu,  1 Jan 2015 14:03:47 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, Michal Sojka <sojkam1@fel.cvut.cz>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 10/10] cli: address: Add --filter-by option\r
+       to      configure       address filtering\r
+In-Reply-To: <87vbkrfs66.fsf@maritornes.cs.unb.ca>\r
+References: <1415147159-19946-1-git-send-email-sojkam1@fel.cvut.cz>\r
+       <1415147159-19946-11-git-send-email-sojkam1@fel.cvut.cz>\r
+       <87vbkrfs66.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.19+6~g8725b09 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 01 Jan 2015 14:03:47 +0200\r
+Message-ID: <m2d26yhfmk.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 01 Jan 2015 12:04:23 -0000\r
+\r
+On Wed, Dec 31 2014, David Bremner <david@tethera.net> wrote:\r
+\r
+> Michal Sojka <sojkam1@fel.cvut.cz> writes:\r
+>\r
+>> This option allows to configure the criterion for duplicate address\r
+>> filtering. Without this option, all unique combinations of name and\r
+>> address parts are printed. This option allows to filter the output\r
+>> more, for example to only contain unique address parts.\r
+>\r
+> I had the feeling there was some "controversy" about the UI here, but\r
+> following back the 3 versions of the series I didn't see it. Does that\r
+> mean we just need to sanity check the code, or are there outstanding\r
+> bikes to shed?\r
+\r
+I have intentionally been guiet on this during the review process of the\r
+other patches to not slow down the acceptance of the others. I have not\r
+got enough time to look the implemenentation or think this last patch\r
+further -- from the user interface point of view I recall seeing there\r
+both useless features (but which might be warranted by implementation\r
+simplicity) and missing features (but which might not be there due to \r
+difficulty in implementation). Also, I am not sure whether the --filter-by\r
+is good option (and options descriptive...)...\r
+\r
+...I'll look into this soon....\r
+\r
+\r
+>\r
+> d\r
+\r
+Tomi\r