Re: [v2 1/3] thread.cc: Avoid empty thread names if possible.

diff --git a/2f/730e00361086213baadef4366fd34592cbbcde b/2f/730e00361086213baadef4366fd34592cbbcde
new file mode 100644 (file)
index 0000000..034361f
--- /dev/null
+++ b/2f/730e00361086213baadef4366fd34592cbbcde
@@ -0,0 +1,72 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D10AC431E64\r
+       for <notmuch@notmuchmail.org>; Sat, 10 Jan 2015 01:18:27 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.438\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id r8VFieAw9cmv for <notmuch@notmuchmail.org>;\r
+       Sat, 10 Jan 2015 01:18:24 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A6F34431E62\r
+       for <notmuch@notmuchmail.org>; Sat, 10 Jan 2015 01:18:24 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Y9sBc-0002VR-1I; Sat, 10 Jan 2015 05:18:24 -0400\r
+Received: (nullmailer pid 8029 invoked by uid 1000); Sat, 10 Jan 2015\r
+       09:18:18 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [v2 1/3] thread.cc: Avoid empty thread names if possible.\r
+In-Reply-To: <1414615905-22554-2-git-send-email-jrosenthal@jhu.edu>\r
+References: <1414615905-22554-1-git-send-email-jrosenthal@jhu.edu>\r
+       <1414615905-22554-2-git-send-email-jrosenthal@jhu.edu>\r
+User-Agent: Notmuch/0.19+10~g215de26 (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 10 Jan 2015 10:18:18 +0100\r
+Message-ID: <87k30vj8o5.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 10 Jan 2015 09:18:28 -0000\r
+\r
+Jesse Rosenthal <jrosenthal@jhu.edu> writes:\r
+\r
+>  \r
+> +#define EMPTY_STRING(s) ((s)[0] == '\0') \r
+> +\r
+\r
+Extra whitespace at end of line. If that's the only issue I can rebase\r
+it away, but maybe you want to enable the standard pre-commit hook?\r
+\r
+>  struct visible _notmuch_thread {\r
+>      notmuch_database_t *notmuch;\r
+>      char *thread_id;\r
+> @@ -330,11 +332,13 @@ _thread_set_subject_from_message (notmuch_thread_t *thread,\r
+>      } else {\r
+>      cleaned_subject = talloc_strdup (thread, subject);\r
+>      }\r
+> +    \r
+Same here. \r
+\r
+>  \r