Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

diff --git a/de/928574d0f228924388d1fc57f647c584a23a50 b/de/928574d0f228924388d1fc57f647c584a23a50
new file mode 100644 (file)
index 0000000..85f1720
--- /dev/null
+++ b/de/928574d0f228924388d1fc57f647c584a23a50
@@ -0,0 +1,110 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 233EE431FC0\r
+       for <notmuch@notmuchmail.org>; Tue,  9 Apr 2013 05:12:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 0-TgwqJ48eYg for <notmuch@notmuchmail.org>;\r
+       Tue,  9 Apr 2013 05:12:36 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6068E431FBD\r
+       for <notmuch@notmuchmail.org>; Tue,  9 Apr 2013 05:12:36 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 4B76C100093;\r
+       Tue,  9 Apr 2013 15:12:34 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, Jed Brown <jed@59A2.org>,\r
+       Jani Nikula <jani@nikula.org>, Karl Fogel <kfogel@red-bean.com>,\r
+       Daniel Bergey <bergey@alum.mit.edu>\r
+Subject: Re: [PATCH] emacs: add missing paren to fix defun in\r
+       notmuch-address.el.\r
+In-Reply-To: <87vc7vgbym.fsf@zancas.localnet>\r
+References: <87wqsfik5l.fsf@floss.red-bean.com>\r
+       <87mwtah2hd.fsf@zancas.localnet>\r
+       <877gkeau42.fsf@floss.red-bean.com>\r
+       <m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>\r
+       <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>\r
+       <m2hajgxli5.fsf@guru.guru-group.fi>\r
+       <87vc7vgbym.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 09 Apr 2013 15:12:34 +0300\r
+Message-ID: <m2ehejykb1.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 09 Apr 2013 12:12:37 -0000\r
+\r
+On Tue, Apr 09 2013, David Bremner wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>> On Tue, Apr 09 2013, Jed Brown wrote:\r
+>>\r
+>>> David Bremner <david@tethera.net> writes:\r
+>>>\r
+>>>> Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to\r
+>>>> do it myself.\r
+>>>\r
+>>> I tested the attached and it's working as expected.  Sent as an\r
+>>> attachment to preserve author information.\r
+>>\r
+>> LGTM (this time tested, too). Also compared diffs by hand, change as announced.\r
+>> comments in id:m26207wgyt.fsf@guru.guru-group.fi (amend!) apply. \r
+>\r
+> There seems to be a few warnings:\r
+>\r
+> In notmuch-bbdb/snarf-from:\r
+> notmuch-address.el:116:26:Warning: reference to free variable\r
+>     `bbdb-get-addresses-headers'\r
+>\r
+> In notmuch-bbdb/snarf-to:\r
+> notmuch-address.el:122:29:Warning: reference to free variable\r
+>     `bbdb-get-addresses-headers'\r
+>\r
+> In end of data:\r
+> notmuch-address.el:143:1:Warning: the following functions are not known to be\r
+>     defined: bbdb-get-addresses, bbdb-update-records, notmuch-show-get-header\r
+>\r
+> Do we need a few defvars?\r
+\r
+For the above set, something like:\r
+\r
+(defvar bbdb-get-addresses-headers)\r
+\r
+(declare-function notmuch-show-get-header "notmuch-show" (header &optional props))\r
+\r
+(declare-function bbdb-get-addresses "bbdb-com" \r
+  (only-first-address\r
+   uninteresting-senders\r
+   get-header-content-function\r
+   &rest get-header-content-function-args))\r
+\r
+(declare-function bbdb-update-records "bbdb-com" (addrs auto-create-p offer-to-create))\r
+\r
+> d\r
+\r
+Tomi\r