Re: [PATCH v2 06/10] cli: refactor insert

diff --git a/85/bce7dbc84dc81e95120c4b0e6a9361ee477f32 b/85/bce7dbc84dc81e95120c4b0e6a9361ee477f32
new file mode 100644 (file)
index 0000000..bd2078e
--- /dev/null
+++ b/85/bce7dbc84dc81e95120c4b0e6a9361ee477f32
@@ -0,0 +1,76 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1389F431FBC\r
+       for <notmuch@notmuchmail.org>; Tue, 16 Sep 2014 12:32:30 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id tOCJu05qOuZm for <notmuch@notmuchmail.org>;\r
+       Tue, 16 Sep 2014 12:32:26 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 33EB8431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 16 Sep 2014 12:32:26 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XTyUC-0006BA-GD; Tue, 16 Sep 2014 16:32:24 -0300\r
+Received: (nullmailer pid 7855 invoked by uid 1000); Tue, 16 Sep 2014\r
+       19:32:16 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Peter Wang <novalazy@gmail.com>\r
+Subject: Re: [PATCH v2 06/10] cli: refactor insert\r
+In-Reply-To: <20140706135728.GE1142@hili.localdomain>\r
+References: <1397653165-15620-1-git-send-email-novalazy@gmail.com>\r
+       <1397653165-15620-7-git-send-email-novalazy@gmail.com>\r
+       <87simgq702.fsf@maritornes.cs.unb.ca>\r
+       <20140706135728.GE1142@hili.localdomain>\r
+User-Agent: Notmuch/0.18.1+97~g56c48dc (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 16 Sep 2014 21:32:16 +0200\r
+Message-ID: <8738brpdj3.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 16 Sep 2014 19:32:30 -0000\r
+\r
+Peter Wang <novalazy@gmail.com> writes:\r
+\r
+> On Sat, 05 Jul 2014 10:18:05 -0300, David Bremner <david@tethera.net> wrote:\r
+>> Peter Wang <novalazy@gmail.com> writes:\r
+>> \r
+>> > -    cleanup_path = tmppath;\r
+>> > -\r
+>> > -    if (! copy_stdin (fdin, fdout))\r
+>> > - goto FAIL;\r
+>> > +    if (! copy_stdin (fdin, fdout)) {\r
+>> > + close (fdout);\r
+>> > + unlink (tmppath);\r
+>> > + return FALSE;\r
+>> > +    }\r
+\r
+I've now pushed up to patch 6 in the series, along with a couple of\r
+patches to deal with SONAME related breakage.\r
+\r
+I did end up squashing this patch in.\r
+\r
+d\r