Re: argument parsing refactoring round3

diff --git a/24/e7c113ae564bae59884afc2e656b5db83ae3e4 b/24/e7c113ae564bae59884afc2e656b5db83ae3e4
new file mode 100644 (file)
index 0000000..8f4b782
--- /dev/null
+++ b/24/e7c113ae564bae59884afc2e656b5db83ae3e4
@@ -0,0 +1,91 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id F3B916DE0AB8\r
+ for <notmuch@notmuchmail.org>; Sat, 25 Apr 2015 12:56:35 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.126\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.126 tagged_above=-999 required=5 tests=[AWL=0.474, \r
+ SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 0S88OrLszDIv for <notmuch@notmuchmail.org>;\r
+ Sat, 25 Apr 2015 12:56:33 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 6E3496DE028C\r
+ for <notmuch@notmuchmail.org>; Sat, 25 Apr 2015 12:56:32 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 20A03100033;\r
+ Sat, 25 Apr 2015 22:56:08 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: argument parsing refactoring round3\r
+In-Reply-To: <87mw2fwn0t.fsf@maritornes.cs.unb.ca>\r
+References: <871tjws8w8.fsf@qmul.ac.uk>\r
+ <1428435042-16503-1-git-send-email-david@tethera.net>\r
+ <20150408143147.GD5218@vilya.online.net>\r
+ <87oamy41nv.fsf@maritornes.cs.unb.ca> <87mw2fwn0t.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.19+109~ge80275e (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 25 Apr 2015 22:56:07 +0300\r
+Message-ID: <m2oamcyobs.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 25 Apr 2015 19:56:36 -0000\r
+\r
+On Sat, Apr 11 2015, David Bremner <david@tethera.net> wrote:\r
+\r
+> David Bremner <david@tethera.net> writes:\r
+>\r
+>> guyzmo <guyzmo+notmuch@m0g.net> writes:\r
+>>\r
+>>> I was wondering whether you had considered actually using `docopt` to\r
+>>> generate the CLI parser from the output.\r
+>\r
+>> As it stands, I'm not particularly annoyed with the notmuch argument\r
+>> parsing code, so I mainly see negative issues about your proposal.\r
+>\r
+> On the other hand, I do find the config handling code annoying, so if\r
+> people have some ideas about that, I am interested to hear them.  There\r
+> is now almost 1000 lines of C in notmuch-config.c, and despite some\r
+> efforts to streamline things, there is a lot of copying and pasting\r
+> every time someone wants to add a configuration option.\r
+\r
+I reviewed the changes -- last ones 'cursory' as I think those don't \r
+break any "real" functionality -- and if help works bad then one can\r
+always resort to testing and reading code >;)...\r
+\r
+...but I did not test -- automated tests (to ensure it doesn't break\r
+anything be handy... more complete would limit anyone's interest to\r
+implement alternate option handling (even further).\r
+\r
+As much I also liked "better" option handling code new code (vast of that)\r
+would also require significant reviewing effort which no-one will like\r
+to do >;/\r
+\r
+With that said, +1 from me to the config handling changes. \r
+(or should I give it some hand-testing (how?)\r
+\r
+Tomi\r
+\r
+>\r
+> d\r