Re: [PATCH 1/2] configure: add a fallback check for zlib

diff --git a/8a/77cd40dbde360a133cb96a9a3a14d533621822 b/8a/77cd40dbde360a133cb96a9a3a14d533621822
new file mode 100644 (file)
index 0000000..3bc4d88
--- /dev/null
+++ b/8a/77cd40dbde360a133cb96a9a3a14d533621822
@@ -0,0 +1,113 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 16662431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 21 May 2014 12:34:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Tb8XHnW9gdn8 for <notmuch@notmuchmail.org>;\r
+       Wed, 21 May 2014 12:34:32 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 68EAB431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 21 May 2014 12:34:32 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 8E87C100090;\r
+       Wed, 21 May 2014 22:34:26 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Fraser Tweedale <frase@frase.id.au>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] configure: add a fallback check for zlib\r
+In-Reply-To: <20140521091304.GT62147@bacardi.hollandpark.frase.id.au>\r
+References: <1399753646-3026-1-git-send-email-xico@atelo.org>\r
+       <536e965c9415e_300d7772fc9@nysa.notmuch>\r
+       <m261ldi98h.fsf@guru.guru-group.fi>\r
+       <536ea7d6a4c86_3c5a8eb3048b@nysa.notmuch>\r
+       <20140521091304.GT62147@bacardi.hollandpark.frase.id.au>\r
+User-Agent: Notmuch/0.18+12~g9d41f94 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 21 May 2014 22:34:25 +0300\r
+Message-ID: <m2ioozori6.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 21 May 2014 19:34:40 -0000\r
+\r
+On Wed, May 21 2014, Fraser Tweedale <frase@frase.id.au> wrote:\r
+\r
+> On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote:\r
+>> Tomi Ollila wrote:\r
+>> > On Sun, May 11 2014, Felipe Contreras <felipe.contreras@gmail.com> wro=\r
+te:\r
+>> >=20\r
+>> > > X=C4=ABc=C3=B2 wrote:\r
+>> > >> Since zlib is part of the base system, FreeBSD chose not to registe=\r
+r it\r
+>> > >> in pkg-config through zlib.pc. As a fallback test, configure will b=\r
+uild\r
+>> > >> and run a zlib version check and make sure the header and library\r
+>> > >> versions are compatible.\r
+>> > >\r
+>> > > We could try to generate our on zlib.pc, this way the configure scri=\r
+pt\r
+>> > > would be cleaner.\r
+>> >=20\r
+>> > But for that we'd need to figure out the version, and is there simpler\r
+>> > robust way to do that some other way ?\r
+>>=20\r
+>> I don't meant to change the code that is checking for the version in the\r
+>> patch, you use the same code, but instead of have_zlib.c gen_zlib_pc.c,\r
+>> or something.\r
+>>=20\r
+>\r
+> [please cc me in replies; I am not subscribed to the list]\r
+>\r
+> I think that the additional complexity outweighs the benefit of a\r
+> somewhat cleaner build script.\r
+>\r
+> If the $vz1, $vz2, et al. are what's bothering you, perhaps we could\r
+> push the complexity of version comparison into have_zlib.c and\r
+> supply the (string) version number as an argument to the program.\r
+> The have_zlib program could do the comparison and exit accordingly,\r
+> and plain old "1.2.5.2" can take its place in the configure script\r
+> once more.\r
+>\r
+> However, I don't see any problems with the patch as it is; I have\r
+> tested it on FreeBSD 10.0 and it works.\r
+\r
+Did you notice=20\r
+\r
+http://mid.gmane.org/1399864172-28227-1-git-send-email-felipe.contreras@gma=\r
+il.com\r
+\r
+:D\r
+\r
+>\r
+> Regards,\r
+>\r
+> Fraser\r
+>\r
+>> --=20\r
+>> Felipe Contreras\r
+\r
+Tomi\r