Add a warning for built_with_use. Thanks to Petteri Räty <betelgeuse@g.o> for

this patch.

svn path=/main/trunk/; revision=15209

diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index 4e83e66539fe825e4601d24af7f951ce6362aa94..36e074c9f129884a6a62a7762166f46cceabce46 100644 (file)
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -432,6 +432,12 @@ class SrcUnpackPatches(PhaseCheck):
                                return ("'%s'" % m.group(1)) + \
                                        " call should be moved to src_prepare from line: %d"
 
+class BuiltWithUse(LineCheck):
+       repoman_check_name = 'ebuild.minorsyn'
+       ignore_line = re.compile(r'^\s*#')
+       re = re.compile('^.*built_with_use')
+       error = errors.BUILT_WITH_USE
+
 # EAPI-4 checks
 class Eapi4IncompatibleFuncs(LineCheck):
        repoman_check_name = 'EAPI.incompatible'
@@ -467,7 +473,6 @@ class Eapi4GoneVars(LineCheck):
                        return ("variable '$%s'" % m.group(1)) + \
                                " is gone in EAPI=4 on line: %d"
 
-
 _constant_checks = tuple((c() for c in (
        EbuildHeader, EbuildWhitespace, EbuildBlankLine, EbuildQuote,
        EbuildAssignment, EbuildUselessDodoc,
@@ -476,7 +481,7 @@ _constant_checks = tuple((c() for c in (
        IUseUndefined, InheritAutotools,
        EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, NoAsNeeded,
        DeprecatedBindnowFlags, SrcUnpackPatches, WantAutoDefaultValue,
-       SrcCompileEconf, Eapi4IncompatibleFuncs, Eapi4GoneVars)))
+       SrcCompileEconf, Eapi4IncompatibleFuncs, Eapi4GoneVars, BuiltWithUse)))
 
 _here_doc_re = re.compile(r'.*\s<<[-]?(\w+)$')
 

diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py
index b62af12b366da6e02c44c905460f91599b4059de..cd1d7e3d74f142a8e65f0a6c7165c5931405e5e7 100644 (file)
--- a/pym/repoman/errors.py
+++ b/pym/repoman/errors.py
@@ -18,3 +18,4 @@ EMAKE_PARALLEL_DISABLED_VIA_MAKEOPTS = 'Upstream parallel compilation bug (MAKEO
 DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d'
 EAPI_DEFINED_AFTER_INHERIT = 'EAPI defined after inherit on line: %d'
 NO_AS_NEEDED = 'Upstream asneeded linking bug (no-as-needed on line: %d)'
+BUILT_WITH_USE = 'built_with_use on line: %d'