[PATCH v2 1/8] emacs: Fix misuse of `notmuch-tag'

diff --git a/21/53a7af3d93d447760293a3b1f80660e888607b b/21/53a7af3d93d447760293a3b1f80660e888607b
new file mode 100644 (file)
index 0000000..e664b06
--- /dev/null
+++ b/21/53a7af3d93d447760293a3b1f80660e888607b
@@ -0,0 +1,98 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 336EA429E47\r
+       for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 17:22:28 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Alv4rioNuHIU for <notmuch@notmuchmail.org>;\r
+       Tue, 22 Oct 2013 17:22:21 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu\r
+       [18.9.25.13])\r
+       by olra.theworths.org (Postfix) with ESMTP id A25B4429E28\r
+       for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 17:22:08 -0700 (PDT)\r
+X-AuditID: 1209190d-b7f528e0000009b4-73-526716b0a6d9\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 1C.30.02484.0B617625; Tue, 22 Oct 2013 20:22:08 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id r9N0M562012255; \r
+       Tue, 22 Oct 2013 20:22:05 -0400\r
+Received: from drake.dyndns.org\r
+       (216-15-114-40.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com\r
+       [216.15.114.40]) (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r9N0M3LB005835\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Tue, 22 Oct 2013 20:22:04 -0400\r
+Received: from amthrax by drake.dyndns.org with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1VYmD5-0008KC-FJ; Tue, 22 Oct 2013 20:22:03 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v2 1/8] emacs: Fix misuse of `notmuch-tag'\r
+Date: Tue, 22 Oct 2013 20:21:54 -0400\r
+Message-Id: <1382487721-31776-2-git-send-email-amdragon@mit.edu>\r
+X-Mailer: git-send-email 1.8.4.rc3\r
+In-Reply-To: <1382487721-31776-1-git-send-email-amdragon@mit.edu>\r
+References: <1382487721-31776-1-git-send-email-amdragon@mit.edu>\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsUixCmqrLtBLD3I4N11CYvVc3ksrt+cyezA\r
+       5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZcxvnMBeMJWj4tj+J0wNjI/Yuhg5OSQETCRm\r
+       TJwMZYtJXLi3Hsjm4hAS2Mco8fTtBlYIZyOjxMtLH5kgnDtMEm9WP4YqmwtUtvAJWD+bgIbE\r
+       tv3LGUFsEQFpiZ13Z7OC2MwCjhKf9y8CquHgEBawkjjWogBisgioSrxeywdSwSvgIHF813d2\r
+       iCuUJBae2gbWyQnU+WbHB7DpQkA1U3aeYZnAyL+AkWEVo2xKbpVubmJmTnFqsm5xcmJeXmqR\r
+       rpFebmaJXmpK6SZGcBhJ8u5gfHdQ6RCjAAejEg+vRXtakBBrYllxZe4hRkkOJiVRXnX+9CAh\r
+       vqT8lMqMxOKM+KLSnNTiQ4wSHMxKIrzNvkDlvCmJlVWpRfkwKWkOFiVx3psc9kFCAumJJanZ\r
+       qakFqUUwWRkODiUJXl9RoKGCRanpqRVpmTklCGkmDk6Q4TxAw1eA1PAWFyTmFmemQ+RPMSpK\r
+       ifPygyQEQBIZpXlwvbA4f8UoDvSKMO8XEaAqHmCKgOt+BTSYCWjwlCUgVxeXJCKkpBoYq8MN\r
+       j5maBbraX7Av3np88/F7i2Ws/ureDG2aqcMqcuiRQYIwk8f+zR5MZ5Yu5rd/E27Q+PG2B+Oj\r
+       N2aroh/lJ37a7z/nVf0Oh4pNzFu7i89ybm1S4H4SPb/kYGqYR8Kyh3P9ZFj9V3y7vuSA3K6l\r
+       zSqB+1deO865UGO16Xd5foENthNdV04/r8RSnJFoqMVcVJwIAG7fbDDOAgAA\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 23 Oct 2013 00:22:28 -0000\r
+\r
+The calling convention for `notmuch-tag' changed in commit 97aa3c06 to\r
+take a list of tag changes instead of a &rest argument, but the call\r
+from `notmuch-search-tag-all' still passed a &rest argument.  This\r
+happened to work for interactive calls because tag-changes would be\r
+nil, so the `apply' call would pass only the query string to\r
+`notmuch-tag' and simply omit the &optional tag-changes argument.\r
+---\r
+ emacs/notmuch.el | 2 +-\r
+ 1 file changed, 1 insertion(+), 1 deletion(-)\r
+\r
+diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+index c47c6b5..e0511c8 100644\r
+--- a/emacs/notmuch.el\r
++++ b/emacs/notmuch.el\r
+@@ -837,7 +837,7 @@ non-authors is found, assume that all of the authors match."\r
+ \r
+ See `notmuch-tag' for information on the format of TAG-CHANGES."\r
+   (interactive)\r
+-  (apply 'notmuch-tag notmuch-search-query-string tag-changes))\r
++  (notmuch-tag notmuch-search-query-string tag-changes))\r
+ \r
+ (defun notmuch-search-buffer-title (query)\r
+   "Returns the title for a buffer with notmuch search results."\r
+-- \r
+1.8.4.rc3\r
+\r