Re: [BUG] [PATCH] Fix appending of Received headers
authorCarl Worth <cworth@cworth.org>
Tue, 24 May 2011 20:33:25 +0000 (13:33 +1700)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:38:19 +0000 (09:38 -0800)
70/0605ce544325a0f62acc829b700216951b199f [new file with mode: 0644]

diff --git a/70/0605ce544325a0f62acc829b700216951b199f b/70/0605ce544325a0f62acc829b700216951b199f
new file mode 100644 (file)
index 0000000..c028a09
--- /dev/null
@@ -0,0 +1,88 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 37833431FD0\r
+       for <notmuch@notmuchmail.org>; Tue, 24 May 2011 13:33:36 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 40pQiZvq1G8z for <notmuch@notmuchmail.org>;\r
+       Tue, 24 May 2011 13:33:35 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id C7EE3431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 24 May 2011 13:33:35 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id 8C64A29A057;\r
+       Tue, 24 May 2011 13:33:34 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 807DD25417E; Tue, 24 May 2011 13:33:34 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Stewart Smith <stewart@flamingspork.com>,\r
+ notmuch <notmuch@notmuchmail.org>\r
+Subject: Re: [BUG] [PATCH] Fix appending of Received headers\r
+In-Reply-To: <878vu6ulev.fsf@flamingspork.com>\r
+References: <878vu6ulev.fsf@flamingspork.com>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Tue, 24 May 2011 13:33:25 -0700\r
+Message-ID: <87ipszltyi.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 24 May 2011 20:33:36 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Tue, 17 May 2011 12:10:32 +1000, Stewart Smith <stewart@flamingspork.com=\r
+> wrote:\r
+> We're not properly concatenating the Received headers if we parse them\r
+> while requesting a header that isn't Received.\r
+\r
+Thanks, Stewart. The fix looks clearly correct.\r
+\r
+> this fixes notmuch-reply address detection in a bunch of situations.\r
+\r
+But can we go one step beyond "a bunch of situations"? Could you send a\r
+message that demonstrates this bug? Or better yet, extend the\r
+test/from-guessing test case to expose the bug?\r
+\r
+I'd prefer to fix the test suite here so that we don't later regress on\r
+this behavior.\r
+\r
+Thanks,\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEUEARECAAYFAk3cFhUACgkQ6JDdNq8qSWil4QCYsjOSQFECSvKGL+1KHSWEjG0w\r
+IACfb5xVO2WiiqM1wKs7/sbviy0DjHQ=\r
+=9pHV\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r