Re: talloc_abort in notmuch_thread_get_tags () when db has been modified

diff --git a/6f/2a570c5dd6516498f66a04137c38305a020ae6 b/6f/2a570c5dd6516498f66a04137c38305a020ae6
new file mode 100644 (file)
index 0000000..1b2319c
--- /dev/null
+++ b/6f/2a570c5dd6516498f66a04137c38305a020ae6
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 90EF96DE028A\r
+ for <notmuch@notmuchmail.org>; Mon,  7 Mar 2016 04:01:37 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.034\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.034 tagged_above=-999 required=5\r
+ tests=[AWL=-0.023, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id i-hE1bqpgyYA for <notmuch@notmuchmail.org>;\r
+ Mon,  7 Mar 2016 04:01:31 -0800 (PST)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 2471B6DE0244\r
+ for <notmuch@notmuchmail.org>; Mon,  7 Mar 2016 04:01:30 -0800 (PST)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1actrQ-0001M5-Tz; Mon, 07 Mar 2016 07:02:04 -0500\r
+Received: (nullmailer pid 14311 invoked by uid 1000);\r
+ Mon, 07 Mar 2016 12:01:25 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Gaute Hope <eg@gaute.vetsj.com>, notmuch@notmuchmail.org\r
+Subject: Re: talloc_abort in notmuch_thread_get_tags () when db has been\r
+ modified\r
+In-Reply-To: <1457341792-astroid-0-2wtydh6y1q-15951@strange>\r
+References: <1453121100-astroid-2-c62fwcrm91-18877@strange>\r
+ <1457341792-astroid-0-2wtydh6y1q-15951@strange>\r
+User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 07 Mar 2016 08:01:25 -0400\r
+Message-ID: <87r3fmts2y.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 07 Mar 2016 12:01:37 -0000\r
+\r
+Gaute Hope <eg@gaute.vetsj.com> writes:\r
+\r
+> as far as I can see, there is _no_ way to catch this error without\r
+> completely crashing the application. I would have to isolate this code\r
+> in a separate process or trap SIGABRT (which is certainly messy).\r
+\r
+I'm not sure what you expect libnotmuch to do here. There's a fatal\r
+"should not happen" error in the memory allocator; it isn't really the\r
+sort of thing one can recover from. It's also not in code we control.\r
+\r
+Of course _why_ this error is happening could still be notmuch's\r
+fault. Can you reproduce the problem under valgrind?\r
+\r
+d\r