Re: [PATCH] emacs: Don't signal an error when reaching the end of the search results.

diff --git a/ce/cecc9e0059d631507722cb69263b8d42ce5835 b/ce/cecc9e0059d631507722cb69263b8d42ce5835
new file mode 100644 (file)
index 0000000..baffcf8
--- /dev/null
+++ b/ce/cecc9e0059d631507722cb69263b8d42ce5835
@@ -0,0 +1,101 @@
+Return-Path: <tomi.ollila@nixu.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9EB1A431FD0\r
+       for <notmuch@notmuchmail.org>; Wed, 28 Dec 2011 12:33:14 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ghbVmYp1Hz3r for <notmuch@notmuchmail.org>;\r
+       Wed, 28 Dec 2011 12:33:14 -0800 (PST)\r
+Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A4FDA431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 28 Dec 2011 12:33:13 -0800 (PST)\r
+Received: from pps.filterd (mail-gw3 [127.0.0.1])\r
+       by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id pBSKWnj4001487;\r
+       Wed, 28 Dec 2011 22:33:10 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by mail-gw3.nixu.fi with ESMTP id 114cs0w2b3-1\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Wed, 28 Dec 2011 22:33:09 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id\r
+       pBSKX9Ms007195; Wed, 28 Dec 2011 22:33:09 +0200\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Don't signal an error when reaching the end of the\r
+       search results.\r
+In-Reply-To: <1324370714-28545-1-git-send-email-dme@dme.org>\r
+References: <1324370714-28545-1-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.10.2+123~g49af79c (http://notmuchmail.org) Emacs/23.3.1\r
+       (i686-pc-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 28 Dec 2011 22:33:09 +0200\r
+Message-ID: <yf662h0mo6y.fsf@taco2.nixu.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,\r
+ 1.0.211,      0.0.0000        definitions=2011-12-28_07:2011-12-28, 2011-12-28,\r
+       1970-01-01 signatures=0\r
+X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0\r
+       ipscore=0 suspectscore=0\r
+       phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0\r
+       reason=mlx\r
+       scancount=1 engine=6.0.2-1012030000 definitions=main-1112280123\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 28 Dec 2011 20:33:14 -0000\r
+\r
+On Tue, 20 Dec 2011 08:45:14 +0000, David Edmondson <dme@dme.org> wrote:\r
+> With the default configuration ('space' moves through the messages\r
+> matching the search and back to the results index at the end) it's\r
+> unnecessary to signal an error when the last message has been read, as\r
+> this is the common case.\r
+> \r
+> Moreover, it's very annoying when `debug-on-error' is t.\r
+> ---\r
+\r
+I'd say '+1' but I could not reproduce the case. In case this is case\r
+that should not happen then I just don't know whetner emacs should\r
+signal error to user or not.\r
+\r
+Tomi\r
+\r
+>  emacs/notmuch.el |    2 +-\r
+>  1 files changed, 1 insertions(+), 1 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index 675a110..2e9973e 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -438,7 +438,7 @@ Complete list of currently available key bindings:\r
+>                               "*")\r
+>                       32 nil nil t))\r
+>                    crypto-switch)\r
+> -      (error "End of search results"))))\r
+> +      (message "End of search results."))))\r
+>  \r
+>  (defun notmuch-search-reply-to-thread (&optional prompt-for-sender)\r
+>    "Begin composing a reply to the entire current thread in a new buffer."\r
+> -- \r
+> 1.7.7.3\r