Re: [PATCH] emacs: escape % in header line format

diff --git a/05/1007b211d08412deed8c900e5a27c0cd229b9e b/05/1007b211d08412deed8c900e5a27c0cd229b9e
new file mode 100644 (file)
index 0000000..f3ddda1
--- /dev/null
+++ b/05/1007b211d08412deed8c900e5a27c0cd229b9e
@@ -0,0 +1,104 @@
+Return-Path: <jinwoo68@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A4BB6431FC9\r
+       for <notmuch@notmuchmail.org>; Thu, 22 Jan 2015 09:49:10 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.639\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.639 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       DNS_FROM_AHBL_RHSBL=2.438, FREEMAIL_ENVFROM_END_DIGIT=1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Ir-RFFwBDFfO for <notmuch@notmuchmail.org>;\r
+       Thu, 22 Jan 2015 09:49:07 -0800 (PST)\r
+Received: from mail-ie0-f179.google.com (mail-ie0-f179.google.com\r
+       [209.85.223.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 7046A431FBC\r
+       for <notmuch@notmuchmail.org>; Thu, 22 Jan 2015 09:49:07 -0800 (PST)\r
+Received: by mail-ie0-f179.google.com with SMTP id x19so2703048ier.10\r
+       for <notmuch@notmuchmail.org>; Thu, 22 Jan 2015 09:49:06 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=xchMqlwDL128EybK/4aOQyk48ZTlHrvAVqFDQQk3A54=;\r
+       b=kL88fXzPDcfIatw4YhgcmxVdr4+1+BE5jNWP9qgAJJJV/r78/jwi6SK8X2rUqzOpui\r
+       SsneU5wuNw/LhenOJthxO0J2mzZRg23Bo93o5qPabrdftCz2NDG3M7KOMS50jCGSnshH\r
+       RPluQ7WYBWd6Dk+GYB+pVGSsgJX0uLPaeYVSchn49OxEcY+OKBHzT3aE3D3Ja4NJwGnY\r
+       tOhXn4dFRlFBAbJMibLA9otf89krqWjRDVgNoBhMT7T79LdO18O+oVV2QLlpYng+DzV0\r
+       5NiOpG7iHxUMugoXuC/izRKdILGW+U62YzSFEsFh1JHS0j0r0bGvPjwA2YaIoFomAdxU\r
+       VF0A==\r
+X-Received: by 10.42.145.5 with SMTP id d5mr4741183icv.8.1421948945950;\r
+       Thu, 22 Jan 2015 09:49:05 -0800 (PST)\r
+Received: from localhost ([2620:0:1000:407c:9166:f28e:7341:7e7c])\r
+       by mx.google.com with ESMTPSA id t1sm5651327igs.0.2015.01.22.09.49.04\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Thu, 22 Jan 2015 09:49:04 -0800 (PST)\r
+From: Jinwoo Lee <jinwoo68@gmail.com>\r
+To: David Bremner <david@tethera.net>, David Bremner <david@tethera.net>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: escape % in header line format\r
+In-Reply-To: <1421915852-13963-1-git-send-email-david@tethera.net>\r
+References: <yq657fwfcjt5.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+       <1421915852-13963-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-apple-darwin13.2.0)\r
+Date: Thu, 22 Jan 2015 09:49:05 -0800\r
+Message-ID: <yq65wq4eaepa.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 22 Jan 2015 17:49:10 -0000\r
+\r
+Yup.  It works!  Thanks for the quick fix.  Is this going to be merged\r
+to HEAD soon?\r
+\r
+-jinwoo\r
+\r
+On Thu, Jan 22, 2015 at 12:37 AM, David Bremner <david@tethera.net> wrote:\r
+> We set header-line-format to the message subject, but if the subject\r
+> contains percents, the next character is interpreted as a formatting\r
+> control, which is not desired.\r
+> ---\r
+>\r
+> You're correct of course. I have no idea how my testing convinced me\r
+> the previous version worked.\r
+>\r
+> emacs/notmuch-show.el | 6 +++++-\r
+>  1 file changed, 5 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 9f6fe07..87b4881 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1198,7 +1198,11 @@ function is used."\r
+>        (notmuch-show-mapc (lambda () (notmuch-show-set-prop :orig-tags (notmuch-show-get-tags))))\r
+>  \r
+>        ;; Set the header line to the subject of the first message.\r
+> -      (setq header-line-format (notmuch-sanitize (notmuch-show-strip-re (notmuch-show-get-subject))))\r
+> +      (setq header-line-format\r
+> +        (replace-regexp-in-string "%" "%%"\r
+> +                        (notmuch-sanitize\r
+> +                         (notmuch-show-strip-re\r
+> +                          (notmuch-show-get-subject)))))\r
+>  \r
+>        (run-hooks 'notmuch-show-hook))))\r
+>  \r
+> -- \r
+> 2.1.4\r