Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()

diff --git a/24/badaff30fa889a474f2a9e3628dfffb58cbd2c b/24/badaff30fa889a474f2a9e3628dfffb58cbd2c
new file mode 100644 (file)
index 0000000..0747e6b
--- /dev/null
+++ b/24/badaff30fa889a474f2a9e3628dfffb58cbd2c
@@ -0,0 +1,88 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8B724431FC7\r
+       for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:17:42 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id g-H4i88JfAMy for <notmuch@notmuchmail.org>;\r
+       Tue, 21 May 2013 07:17:38 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4C6DA431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:17:38 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id A50D21002C3;\r
+       Tue, 21 May 2013 17:17:37 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()\r
+In-Reply-To: <1369052664-17869-3-git-send-email-felipe.contreras@gmail.com>\r
+References: <1369052664-17869-1-git-send-email-felipe.contreras@gmail.com>\r
+       <1369052664-17869-3-git-send-email-felipe.contreras@gmail.com>\r
+User-Agent: Notmuch/0.15.2+99~g7e455bc (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 21 May 2013 17:17:37 +0300\r
+Message-ID: <m2vc6c4dtq.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: Ali Polatel <alip@exherbo.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 21 May 2013 14:17:42 -0000\r
+\r
+On Mon, May 20 2013, Felipe Contreras <felipe.contreras@gmail.com> wrote:\r
+\r
+> It has never existed in Ruby (maybe JRuby). Fortunately the symbols are\r
+> loaded lazily, so nobody would notice unless they try\r
+> 'query::count_messages'.\r
+>\r
+> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\r
+\r
+This patch could be pushed on it's own, but someone (like Ali) could\r
+comment on the change as searches on both UINT2FIX() & UINT2NUM()\r
+provides (IMH) insatisfactory results...\r
+\r
+Tomi\r
+\r
+> ---\r
+>  bindings/ruby/query.c | 2 +-\r
+>  1 file changed, 1 insertion(+), 1 deletion(-)\r
+>\r
+> diff --git a/bindings/ruby/query.c b/bindings/ruby/query.c\r
+> index e5ba1b7..1658ede 100644\r
+> --- a/bindings/ruby/query.c\r
+> +++ b/bindings/ruby/query.c\r
+> @@ -180,5 +180,5 @@ notmuch_rb_query_count_messages (VALUE self)\r
+>       * (function may return 0 after printing a message)\r
+>       * Thus there is nothing we can do here...\r
+>       */\r
+> -    return UINT2FIX(notmuch_query_count_messages(query));\r
+> +    return UINT2NUM(notmuch_query_count_messages(query));\r
+>  }\r
+> -- \r
+> 1.8.3.rc3.286.g3d43083\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r