Re: [PATCH] contrib: pick: tidy up pick-format-field

diff --git a/0e/605316502b651b99570af49f2176f1c41d6315 b/0e/605316502b651b99570af49f2176f1c41d6315
new file mode 100644 (file)
index 0000000..74c2dfc
--- /dev/null
+++ b/0e/605316502b651b99570af49f2176f1c41d6315
@@ -0,0 +1,76 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 459C5431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 16 Sep 2013 13:15:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 4YLNCdYGZLRZ for <notmuch@notmuchmail.org>;\r
+       Mon, 16 Sep 2013 13:15:37 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id A5878431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 16 Sep 2013 13:15:37 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 1FA801000B2;\r
+       Mon, 16 Sep 2013 23:15:30 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] contrib: pick: tidy up pick-format-field\r
+In-Reply-To: <1379234477-14089-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1379234477-14089-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.16+86~g2d126a3 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 16 Sep 2013 23:15:29 +0300\r
+Message-ID: <m2y56wcyla.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 16 Sep 2013 20:15:45 -0000\r
+\r
+On Sun, Sep 15 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> Previously this function used a temporary variable to store the return\r
+> value but we can just use the return value of the cond statement\r
+> directly.\r
+>\r
+> The only tiny subtlety is that in one case (subject) we need to\r
+> slightly reorder the logic to make sure the formatted-field is the\r
+> last thing computed.\r
+> ---\r
+\r
+> This follows Tomi's suggestion in id:m2ob7vg24n.fsf@guru.guru-group.fi\r
+\r
+LGTM\r
+\r
+Tomi\r
+\r
+> and simplifies the code here slightly. This patch applies on top of the\r
+> series at id:1378092488-32050-1-git-send-email-markwalters1009@gmail.com\r
+>\r
+> (It also includes one small whitespace fix-up for the face for the tags)\r
+>\r
+>\r
+>  contrib/notmuch-pick/notmuch-pick.el |   49 ++++++++++++++-------------------\r
+>  1 files changed, 21 insertions(+), 28 deletions(-)\r
+>\r