Re: [PATCH v5 07/12] insert: add --folder option

diff --git a/1c/4e0804ca8087b8413efe6ce10bcb157852b40b b/1c/4e0804ca8087b8413efe6ce10bcb157852b40b
new file mode 100644 (file)
index 0000000..3aeffc1
--- /dev/null
+++ b/1c/4e0804ca8087b8413efe6ce10bcb157852b40b
@@ -0,0 +1,89 @@
+Return-Path: <novalazy@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C1F21431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 19:00:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.099\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ajwqkkMv58fC for <notmuch@notmuchmail.org>;\r
+       Sat, 27 Apr 2013 19:00:46 -0700 (PDT)\r
+Received: from mail-pd0-f180.google.com (mail-pd0-f180.google.com\r
+       [209.85.192.180]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id B8C25431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 19:00:46 -0700 (PDT)\r
+Received: by mail-pd0-f180.google.com with SMTP id u10so3062894pdi.39\r
+       for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 19:00:44 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=x-received:date:message-id:from:to:cc:subject:in-reply-to\r
+       :references:mime-version:content-type:content-disposition\r
+       :content-transfer-encoding;\r
+       bh=WxGbjGl445yJHmaVcqGL+UgZ5ZZm+x1K0DugwLzJ9K8=;\r
+       b=XAgFpXmeR1COynrIgXp1mipQT7EJEiN8HctCunMjzcqPVrge49YlYBk7rAkwxMU37E\r
+       Rx+hHY8fPnT9MicfszPlKhaQ02zFF6xfA1Jx4pFkyFot5GsXUtLjJQ4IKK/Uap1W0p8L\r
+       E9zR8po+YlUG7XVtqK+reNfu1M8rAsmRwd0R0Juz7RIn1YztbnCWzOFcAMqqJhNKHOrt\r
+       LJ+dAwutvqhQiB0J2prnTIUAsFdG2x1P1tMbUm+3z4Nu/CAkpRHMgDIrt+1W7EORPKYF\r
+       ia9HAj8hOYrWIN6oIN9DSB2AuJ/i78/+Wp0zz/RdT0G3g+0lLwJXCQKYfkJ0TfTrDTip\r
+       GFLg==\r
+X-Received: by 10.66.192.195 with SMTP id hi3mr36535004pac.61.1367114444750;\r
+       Sat, 27 Apr 2013 19:00:44 -0700 (PDT)\r
+Received: from localhost (215.42.233.220.static.exetel.com.au.\r
+       [220.233.42.215])\r
+       by mx.google.com with ESMTPSA id sg4sm146755pbc.7.2013.04.27.19.00.41\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Sat, 27 Apr 2013 19:00:43 -0700 (PDT)\r
+Date: Sun, 28 Apr 2013 12:00:38 +1000\r
+Message-ID: <20130428120038.GA2154@hili.localdomain>\r
+From: Peter Wang <novalazy@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH v5 07/12] insert: add --folder option\r
+In-Reply-To: <87zjwjpslc.fsf@nikula.org>\r
+References: <1364942517-6982-1-git-send-email-novalazy@gmail.com>\r
+       <1364942517-6982-8-git-send-email-novalazy@gmail.com>\r
+       <87zjwjpslc.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: 8bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 28 Apr 2013 02:00:48 -0000\r
+\r
+On Sun, 28 Apr 2013 00:32:47 +0300, Jani Nikula <jani@nikula.org> wrote:\r
+> > +    notmuch_opt_desc_t options[] = {\r
+> > +  { NOTMUCH_OPT_STRING, &folder, "folder", 0, 0 },\r
+> > +  { NOTMUCH_OPT_END, 0, 0, 0, 0 }\r
+> > +    };\r
+> > +\r
+> > +    opt_index = parse_arguments (argc, argv, options, 1);\r
+> > +\r
+> > +    if (opt_index < 0) {\r
+> > +  fprintf (stderr, "Error: bad argument to notmuch insert: %s\n",\r
+> > +           argv[-opt_index]);\r
+> \r
+> I'm too tired to check what's correct, but argv[-opt_index] isn't.\r
+\r
+Nice catch.  I'll just delete that message as parse_arguments\r
+already prints a message, like other callers.\r
+\r
+Peter\r