Re: [PATCH] emacs: show: make id links respect window

diff --git a/ac/9e2128ac8f119e3995a085876602bd286a584f b/ac/9e2128ac8f119e3995a085876602bd286a584f
new file mode 100644 (file)
index 0000000..190d33e
--- /dev/null
+++ b/ac/9e2128ac8f119e3995a085876602bd286a584f
@@ -0,0 +1,109 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EF22A431FBC\r
+       for <notmuch@notmuchmail.org>; Tue, 25 Dec 2012 03:04:52 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id yyrAkiKXi+qJ for <notmuch@notmuchmail.org>;\r
+       Tue, 25 Dec 2012 03:04:49 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id C1B22431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 25 Dec 2012 03:04:48 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1TnSJJ-0005z3-AI; Tue, 25 Dec 2012 11:04:41 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1TnSJI-0005Cq-Vr; Tue, 25 Dec 2012 11:04:37 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: show: make id links respect window\r
+In-Reply-To: <87bodjfnt0.fsf@zancas.localnet>\r
+References: <1355958602-16752-1-git-send-email-markwalters1009@gmail.com>\r
+       <87bodjfnt0.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.14+236~g1d0044f (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 25 Dec 2012 11:04:39 +0000\r
+Message-ID: <87mwx2jsu0.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 743ce505548e1d48a5755a25b381a98e (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 25 Dec 2012 11:04:53 -0000\r
+\r
+\r
+On Mon, 24 Dec 2012, David Bremner <david@tethera.net> wrote:\r
+> Mark Walters <markwalters1009@gmail.com> writes:\r
+>\r
+>> I think this is a bug but that could be debated. It is particularly\r
+>> easy to trigger with notmuch pick because that uses the split pane\r
+>> while focus usually remains in the `pick' pane rather than the `show'\r
+>> pane.\r
+>\r
+> I can imagine that people would want/like the "open in other window" \r
+> effect of the current code, even if the reason is a bug.\r
+\r
+That's definitely possible. I generally expect a mouse click to select\r
+the window I click and this feels counter intuitive. I think that some\r
+people might like an option "open this link in a new window" but I would\r
+guess that would like that whether they clicked or pressed RET on the\r
+button.\r
+\r
+>>                       'action `(lambda (arg)\r
+>>                                  (notmuch-show ,(third link)))\r
+\r
+> Can you (or someone) explain why backquote is needed here? Is this some\r
+> kind of workaround for lack of lexical scope? If so, maybe a comment.\r
+\r
+I think this is a reasonably standard use: we want "(third link)"  to be\r
+evaluated when the button is made, but we want the rest of the action to\r
+be evaluated when the action is called. \r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+>\r
+> d\r