--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id D893C431FB6\r
+ for <notmuch@notmuchmail.org>; Thu, 23 Jan 2014 10:15:59 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Mkl3i3E8vpRw for <notmuch@notmuchmail.org>;\r
+ Thu, 23 Jan 2014 10:15:53 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 7CE89431FAF\r
+ for <notmuch@notmuchmail.org>; Thu, 23 Jan 2014 10:15:53 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1W6OoZ-00067U-CG; Thu, 23 Jan 2014 18:15:48 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1W6OnO-0008LB-Ph; Thu, 23 Jan 2014 18:14:33 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] emacs: defconst notmuch-emacs-version to a value\r
+ during byte compilation\r
+In-Reply-To: <1390135903-28167-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1390135903-28167-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Thu, 23 Jan 2014 18:12:49 +0000\r
+Message-ID: <8738kezhwe.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-Geographic: According to ripencc,\r
+ this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: cb9a0b326e2b7d3a3b02a7a069e9b3e5 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.0 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 23 Jan 2014 18:16:00 -0000\r
+\r
+\r
+Hi\r
+\r
+I like this. However, something odd seems to happen with version.\r
+\r
+If I make and then commit a small change to emacs/notmuch-tree.el and then\r
+remake then version string in the cli nor in emacs seems to be\r
+updated. If I make clean and then make it is updated.\r
+\r
+OTOH if i make then commit a small change to notmuch.c then make again\r
+then the cli seems to get a new version but emacs doesn't.\r
+\r
+I think that this problem (if it's not just stupidity on my part) is\r
+orthogonal to this patch but thought it worth mentioning.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+On Sun, 19 Jan 2014, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> The notmuch cli program and emacs lisp versions may differ. For now\r
+> we can help users with their emacs client problems better if we can\r
+> ask what version of emacs MUA they are running. In the future we can\r
+> put the emacs MUA version to User-Agent: string in outgoing mail.\r
+> ---\r
+> emacs/Makefile.local | 4 +++-\r
+> emacs/notmuch-lib.el | 7 +++++++\r
+> 2 files changed, 10 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/emacs/Makefile.local b/emacs/Makefile.local\r
+> index 42bfbd9..1b2db7e 100644\r
+> --- a/emacs/Makefile.local\r
+> +++ b/emacs/Makefile.local\r
+> @@ -40,7 +40,9 @@ CLEAN+=$(dir)/.eldeps $(dir)/.eldeps.tmp\r
+> \r
+> ifeq ($(HAVE_EMACS),1)\r
+> %.elc: %.el $(global_deps)\r
+> - $(call quiet,EMACS) --directory emacs -batch -f batch-byte-compile $<\r
+> + $(call quiet,EMACS) --directory emacs \\r
+> + --eval "(setq notmuch--version \"$(VERSION)\")" \\r
+> + -batch -f batch-byte-compile $<\r
+> endif\r
+> \r
+> ifeq ($(WITH_EMACS),1)\r
+> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el\r
+> index 2be409b..81eed54 100644\r
+> --- a/emacs/notmuch-lib.el\r
+> +++ b/emacs/notmuch-lib.el\r
+> @@ -168,6 +168,13 @@ Otherwise the output will be returned"\r
+> (notmuch-check-exit-status status (cons notmuch-command args) output)\r
+> output)))\r
+> \r
+> +;; defconst notmuch-emacs-version to a value during build-time byte compilation\r
+> +(defconst notmuch-emacs-version\r
+> + (eval-when-compile (if (boundp 'notmuch--version)\r
+> + notmuch--version\r
+> + "not-compiled"))\r
+> + "Version string of this version of Notmuch Emacs MUA.")\r
+> +\r
+> (defun notmuch-version ()\r
+> "Return a string with the notmuch version number."\r
+> (let ((long-string\r
+> -- \r
+> 1.8.4.2\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff