Re: [PATCH v4 5/6] cli: search: Add configurable way to filter out duplicate addresses

diff --git a/26/6f41162072afb422df367e2719705673a266f2 b/26/6f41162072afb422df367e2719705673a266f2
new file mode 100644 (file)
index 0000000..ce057e2
--- /dev/null
+++ b/26/6f41162072afb422df367e2719705673a266f2
@@ -0,0 +1,97 @@
+Return-Path: <sojkam1@fel.cvut.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1F5C7431FCB\r
+       for <notmuch@notmuchmail.org>; Thu, 30 Oct 2014 14:42:21 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id u1hw+8cjpkqz for <notmuch@notmuchmail.org>;\r
+       Thu, 30 Oct 2014 14:42:13 -0700 (PDT)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id 21CD6431FC2\r
+       for <notmuch@notmuchmail.org>; Thu, 30 Oct 2014 14:42:13 -0700 (PDT)\r
+Received: from localhost (unknown [192.168.200.7])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id B8A205CCFD4;\r
+       Thu, 30 Oct 2014 22:42:11 +0100 (CET)\r
+X-Virus-Scanned: IMAP STYX AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+       by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new,\r
+       port 10044)\r
+       with ESMTP id 5JGoEgklQqgv; Thu, 30 Oct 2014 22:42:07 +0100 (CET)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id 9D8F55CCFD1;\r
+       Thu, 30 Oct 2014 22:42:07 +0100 (CET)\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.84)\r
+       (envelope-from <sojkam1@fel.cvut.cz>)\r
+       id 1XjxTm-0005zv-2s; Thu, 30 Oct 2014 22:42:02 +0100\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>,\r
+ Mark Walters <markwalters1009@gmail.com>,     notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 5/6] cli: search: Add configurable way to filter        out\r
+       duplicate addresses\r
+In-Reply-To: <m2zjceueg4.fsf@guru.guru-group.fi>\r
+References: <1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz>\r
+       <1414421455-3037-6-git-send-email-sojkam1@fel.cvut.cz>\r
+       <87egtqug4t.fsf@qmul.ac.uk> <m2zjceueg4.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.18.2+157~ga00d359 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 30 Oct 2014 22:42:02 +0100\r
+Message-ID: <871tppck0l.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 30 Oct 2014 21:42:21 -0000\r
+\r
+On Thu, Oct 30 2014, Tomi Ollila wrote:\r
+> On Thu, Oct 30 2014, Mark Walters <markwalters1009@gmail.com> wrote:\r
+>\r
+>> On Mon, 27 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+>>> This adds an algorithm to filter out duplicate addresses from address\r
+>>> outputs (sender, receivers). The algorithm can be configured with\r
+>>> --filter-by command line option.\r
+>>>\r
+>>> The code here is an extended version of a patch from Jani Nikula.\r
+>>\r
+>> Hi\r
+>>\r
+>> As this is getting into the more controversial bike shedding region I\r
+>> wonder if it would be worth splitting this into 2 patches: the first\r
+>> could do the default dedupe based on name/address and the second could\r
+>> do add the filter-by options. \r
+>>\r
+>> I think the default deduping is obviously worth doing but I am not sure\r
+>> about the rest. In any case I think the default deduping could go in\r
+>> pre-freeze but I would recommend the rest is left until after.\r
+>\r
+> I can agree with that, but there is one hard thing to resolve: \r
+> "naming things"(*)\r
+>\r
+> (*) http://martinfowler.com/bliki/TwoHardThings.html\r
+>\r
+> With all rest ignored (sorry no time to work on this in more detail now),\r
+> this default deduping could be done with single argument '--unique'...\r
+\r
+I would agree that --unique is slightly better than --filter-by, but I\r
+don't see what is so attractive on having no deduplication at all.\r
+Anyway, I'll keep it in v5 as it is now and we can add\r
+--unique=no/none/whatever later.\r
+\r
+-Michal\r