--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0E2C1429E2E\r
+ for <notmuch@notmuchmail.org>; Sun, 2 Jun 2013 10:26:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 07JLb-8f5E1i for <notmuch@notmuchmail.org>;\r
+ Sun, 2 Jun 2013 10:25:58 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id ECD0D431FBC\r
+ for <notmuch@notmuchmail.org>; Sun, 2 Jun 2013 10:25:57 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1UjC2N-0000fN-QP; Sun, 02 Jun 2013 18:25:50 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1UjC2N-00029p-BR; Sun, 02 Jun 2013 18:25:47 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: replace setq + let with let*\r
+In-Reply-To: <1370185351-23834-1-git-send-email-david@tethera.net>\r
+References: <1370175370-13561-1-git-send-email-david@tethera.net>\r
+ <1370185351-23834-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Sun, 02 Jun 2013 18:25:36 +0100\r
+Message-ID: <878v2sv2zz.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 67eabe4b552f1eef3ecffe4c3d34f2f5 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -0.0 points.\r
+ Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Jun 2013 17:26:06 -0000\r
+\r
+\r
+On Sun, 02 Jun 2013, david@tethera.net wrote:\r
+> From: David Bremner <bremner@debian.org>\r
+>\r
+> I found several places where a setq is immediately followed by a let\r
+> or a let*. This seems to be the pessimal combination, with the\r
+> implicit scope of the setq combined with the extra indentation of the let.\r
+> I combined these cases into a single let* which I think is easier to read.\r
+> In two places I turned a single clause let into a let*.\r
+> ---\r
+> emacs/notmuch-hello.el | 4 ++--\r
+> emacs/notmuch-show.el | 4 ++--\r
+> emacs/notmuch.el | 5 ++---\r
+> 3 files changed, 6 insertions(+), 7 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+> index c1c6f4b..15e3614 100644\r
+> --- a/emacs/notmuch-hello.el\r
+> +++ b/emacs/notmuch-hello.el\r
+> @@ -260,8 +260,8 @@ afterwards.")\r
+> (defun notmuch-hello-search (&optional search)\r
+> (interactive)\r
+> (unless (null search)\r
+> - (setq search (notmuch-hello-trim search))\r
+> - (let ((history-delete-duplicates t))\r
+> + (let* ((search (notmuch-hello-trim search))\r
+> + (history-delete-duplicates t))\r
+> (add-to-history 'notmuch-search-history search)))\r
+> (notmuch-search search notmuch-search-oldest-first nil nil\r
+\r
+These look good to me except I don't see why the above is a let* not a\r
+let?\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+> #'notmuch-hello-search-continuation))\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 18b4671..e8c8343 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1734,8 +1734,8 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."\r
+> \r
+> See `notmuch-tag' for information on the format of TAG-CHANGES."\r
+> (interactive)\r
+> - (setq tag-changes (notmuch-tag (notmuch-show-get-message-id) tag-changes))\r
+> - (let* ((current-tags (notmuch-show-get-tags))\r
+> + (let* ((tag-changes (notmuch-tag (notmuch-show-get-message-id) tag-changes))\r
+> + (current-tags (notmuch-show-get-tags))\r
+> (new-tags (notmuch-update-tags current-tags tag-changes)))\r
+> (unless (equal current-tags new-tags)\r
+> (notmuch-show-set-tags new-tags))))\r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index af107e2..edb5a1c 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -904,9 +904,8 @@ Other optional parameters are used as follows:\r
+> target-line: The line number to move to if the target thread does not\r
+> appear in the search results."\r
+> (interactive)\r
+> - (if (null query)\r
+> - (setq query (notmuch-read-query "Notmuch search: ")))\r
+> - (let ((buffer (get-buffer-create (notmuch-search-buffer-title query))))\r
+> + (let* ((query (or query (notmuch-read-query "Notmuch search: ")))\r
+> + (buffer (get-buffer-create (notmuch-search-buffer-title query))))\r
+> (switch-to-buffer buffer)\r
+> (notmuch-search-mode)\r
+> ;; Don't track undo information for this buffer\r
+> -- \r
+> 1.8.2.rc2\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff