Re: [PATCH v2 2/3] contrib: pick: remove hack notmuch-pick-show-match-message-with...

diff --git a/0a/844b9eb792492ae6a29cae4abfef44854ea73c b/0a/844b9eb792492ae6a29cae4abfef44854ea73c
new file mode 100644 (file)
index 0000000..7e5e953
--- /dev/null
+++ b/0a/844b9eb792492ae6a29cae4abfef44854ea73c
@@ -0,0 +1,84 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5F15F431FCB\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 09:30:54 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id bDfLTrMuYiYX for <notmuch@notmuchmail.org>;\r
+       Sun, 30 Jun 2013 09:30:48 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 3C8F2431FC2\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 09:30:48 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UtKWU-0003LT-1x; Sun, 30 Jun 2013 13:30:46 -0300\r
+Received: (nullmailer pid 15010 invoked by uid 1000); Sun, 30 Jun 2013\r
+       16:30:42 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 2/3] contrib: pick: remove hack\r
+       notmuch-pick-show-match-message-with-wait\r
+In-Reply-To: <1372582512-10777-3-git-send-email-markwalters1009@gmail.com>\r
+References: <1372582512-10777-1-git-send-email-markwalters1009@gmail.com>\r
+       <1372582512-10777-3-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.15.2+193~gb7df509 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 30 Jun 2013 13:30:42 -0300\r
+Message-ID: <87li5rtvbh.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 30 Jun 2013 16:30:54 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> +(defvar notmuch-pick-open-target nil)\r
+> +(make-variable-buffer-local 'notmuch-pick-open-target)\r
+\r
+What do people think about adding a code style suggestion/requirement\r
+for elisp that all variables have docstrings, even if intended for\r
+internal use?  It's true the existing code doesn't really meet this\r
+standard.\r
+\r
+>  (defvar notmuch-pick-buffer-name nil)\r
+>  (make-variable-buffer-local 'notmuch-pick-buffer-name)\r
+>  ;; This variable is the window used for the message pane. It is set\r
+> @@ -349,8 +351,8 @@ Does NOT change the database."\r
+>    (notmuch-pick (notmuch-search-find-thread-id)\r
+>                  notmuch-search-query-string\r
+>              nil\r
+> -                (notmuch-prettify-subject (notmuch-search-find-subject)))\r
+> -  (notmuch-pick-show-match-message-with-wait))\r
+> +                (notmuch-prettify-subject (notmuch-search-find-subject))\r
+> +            t))\r
+\r
+I think my previous complaint can be reformulated as (essentially) both\r
+notmuch-pick and notmuch-pick-open-target could use (better) docstrings.\r
+\r
+As you say, the hack removed is quite horrible, so I'd be willing to\r
+merge the patches anyway. OTOH, more documentation might make it so that\r
+more than one person can understand the notmuch-pick code.\r
+\r
+d\r
+\r