Re: [PATCH v5 0/2] lib: drop mbox support, replace header parser with gmime

diff --git a/f8/c2af3f7d5c89b91f1246be879e0cd12def97d6 b/f8/c2af3f7d5c89b91f1246be879e0cd12def97d6
new file mode 100644 (file)
index 0000000..66d7c6e
--- /dev/null
+++ b/f8/c2af3f7d5c89b91f1246be879e0cd12def97d6
@@ -0,0 +1,104 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8B809431FBF\r
+       for <notmuch@notmuchmail.org>; Fri,  4 Apr 2014 14:26:43 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id jhRy1L4yOGpx for <notmuch@notmuchmail.org>;\r
+       Fri,  4 Apr 2014 14:26:36 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu\r
+       [18.9.25.13])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 4EE72431FAF\r
+       for <notmuch@notmuchmail.org>; Fri,  4 Apr 2014 14:26:36 -0700 (PDT)\r
+X-AuditID: 1209190d-f79776d000000ce9-19-533f238bf7fe\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       (using TLS with cipher AES256-SHA (256/256 bits))\r
+       (Client did not present a certificate)\r
+       by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 53.D4.03305.B832F335; Fri,  4 Apr 2014 17:26:35 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id s34LQXSH031635; \r
+       Fri, 4 Apr 2014 17:26:35 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s34LQVui001759\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Fri, 4 Apr 2014 17:26:33 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1WWBd9-00041T-Db; Fri, 04 Apr 2014 17:26:31 -0400\r
+Date: Fri, 4 Apr 2014 17:26:31 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH v5 0/2] lib: drop mbox support, replace header parser\r
+       with gmime\r
+Message-ID: <20140404212557.GB6404@mit.edu>\r
+References: <cover.1396214154.git.jani@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <cover.1396214154.git.jani@nikula.org>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IR4hRV1u1Wtg82WPRMzKJpurPF9ZszmR2Y\r
+       PG7df83u8WzVLeYApigum5TUnMyy1CJ9uwSujP/XnzMV/Gat2L4qpIHxNEsXIyeHhICJxObp\r
+       n9kgbDGJC/fWA9lcHEICs5kkbr1+zAySEBLYwChxf6UIROIUk8SbszehqpYwSkzc0wHWziKg\r
+       IrFg0WpWEJtNQENi2/7ljCC2iICixOaT+8FsZgFpiW+/m5lAbGGBMIllf3vBzuAV0JY4eHAK\r
+       K8Q2I4kpV66zQcQFJU7OfMIC0aslcePfS6BeDrA5y/9xgIQ5BYwlph5/B1YiCnTClJPb2CYw\r
+       Cs1C0j0LSfcshO4FjMyrGGVTcqt0cxMzc4pTk3WLkxPz8lKLdI30cjNL9FJTSjcxgkNakncH\r
+       47uDSocYBTgYlXh4O3bYBQuxJpYVV+YeYpTkYFIS5e1SsA8W4kvKT6nMSCzOiC8qzUktPsQo\r
+       wcGsJMLL8ROonDclsbIqtSgfJiXNwaIkzvvW2ipYSCA9sSQ1OzW1ILUIJivDwaEkwVujBDRU\r
+       sCg1PbUiLTOnBCHNxMEJMpwHaPgBkBre4oLE3OLMdIj8KUZFKXFeZ5CEAEgiozQPrheWcl4x\r
+       igO9Isw7H6SKB5iu4LpfAQ1mAhrcEAZydXFJIkJKqoFxD8unbSIP4v/8qLd3mvaWxUydjd9h\r
+       nla5kOuChv3+f3Y5pNtaL32goK/+xNJ3f8KLFq53kU/tdXzm/P2qVbvMU0ql7fSzbVHnOD1f\r
+       TWOv3XJNnum9m5wU/6olBxbvZlj+Lb+u/gwf50wxlbYvZpp2z+zNd825Ef/1xrs+ja6/UV9z\r
+       Yv+dydZTYinOSDTUYi4qTgQAdHeKThQDAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 04 Apr 2014 21:26:43 -0000\r
+\r
+LGTM.\r
+\r
+Quoth Jani Nikula on Mar 31 at 12:21 am:\r
+> This is v5 of id:1395604866-19188-1-git-send-email-jani@nikula.org\r
+> addressing Austin's review. The most significant change is the new patch\r
+> dropping support for single-message mbox files. Diff between the\r
+> versions is at the end of this cover letter.\r
+> \r
+> BR,\r
+> Jani.\r
+> \r
+> \r
+> Jani Nikula (2):\r
+>   lib: drop support for single-message mbox files\r
+>   lib: replace the header parser with gmime\r
+> \r
+>  lib/database.cc       |  15 +-\r
+>  lib/index.cc          |  72 +--------\r
+>  lib/message-file.c    | 413 ++++++++++++++++++++------------------------------\r
+>  lib/notmuch-private.h |  55 +++----\r
+>  test/T050-new.sh      |  26 ++--\r
+>  5 files changed, 216 insertions(+), 365 deletions(-)\r
+> \r