Re: [PATCH] Don't bother checking for mbox files

diff --git a/68/b0d1ac55c14a67b4a290f628b7148cca18187f b/68/b0d1ac55c14a67b4a290f628b7148cca18187f
new file mode 100644 (file)
index 0000000..94f4337
--- /dev/null
+++ b/68/b0d1ac55c14a67b4a290f628b7148cca18187f
@@ -0,0 +1,116 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id C065C6DE1894\r
+ for <notmuch@notmuchmail.org>; Sun, 13 Mar 2016 05:49:47 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.556\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.556 tagged_above=-999 required=5 tests=[AWL=0.164,\r
+  DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\r
+ RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id aMPacOtH7BWg for <notmuch@notmuchmail.org>;\r
+ Sun, 13 Mar 2016 05:49:46 -0700 (PDT)\r
+Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com\r
+ [74.125.82.46]) by arlo.cworth.org (Postfix) with ESMTPS id 96E2F6DE1890 for\r
+ <notmuch@notmuchmail.org>; Sun, 13 Mar 2016 05:49:45 -0700 (PDT)\r
+Received: by mail-wm0-f46.google.com with SMTP id p65so70153332wmp.1\r
+ for <notmuch@notmuchmail.org>; Sun, 13 Mar 2016 05:49:45 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=nikula-org.20150623.gappssmtp.com; s=20150623;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version; bh=RuyyUyY+WCsOHTJcRhRivkAIhlk45H/xet/vdC4uqs8=;\r
+ b=PpJkW7tKcBU8R/vAz6QF9TBTfCAD2HFO76WU5ZnmOKV/ph/ukFYuW4HiUwKjaPPqwF\r
+ ck5N06YISB4bUrJp4PX8HtGG4zIW/WHJMmCxxnzQSn6yx8pd/VAAQCm4DZnR+CpJDld3\r
+ 9bm3PEtDU6RIPT0E8KuQcsbAnmihX8ALACc4FDmtG1qzFiIgk7mE1VPMyW0EZPmBzYO9\r
+ Sb+ekHj/UwlgxzoZ+5bPxsPQp2TyNKbmOGDAc+masph9WaIfrYUipt21IW79ZRU1ygzI\r
+ Qwdl8fuDe94GqkGgrkAkEzFyWRFlpghX3uRjAzdFGHEW9PnNq4Ynj686oKr5Y4RoEuI1\r
+ U5Iw==\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+ :user-agent:date:message-id:mime-version;\r
+ bh=RuyyUyY+WCsOHTJcRhRivkAIhlk45H/xet/vdC4uqs8=;\r
+ b=CoeJAN8IHjIKUnxfJGoQE6yluNCUb0KvSWWf8LhdLfms8PSv2fU4J4aoZpdbvxX1Op\r
+ DjkXXQY219cDdb2GnY5okUQ42gYo/2PgEnivLpRWWphBVbjapbtChPmqYd+8Qv1BkgIO\r
+ +r5zVcQQyc3tvBNUjvHXKWXtEPoyVDj5+M/zhj535tgt3JbjN0HjRDYMifcL5XkCwaaV\r
+ k0wa6YwYE3X69o3xT+BuC11ZEKGYkmaN4iZLibwhkmTX5Xz6F4rU7aZ8K+5Au6OjhbmG\r
+ Aer2+9mGVSZh2chHjA9RnLqLdfDQrxB62SWNl4UPwJt0iVVqxAm4xocnkpivEc104uSl\r
+ WHTQ==\r
+X-Gm-Message-State:\r
+ AD7BkJKom0YWKyyOQAEfXQ3QQP/3TG+U9b3VI3JpTwgizvHnY0wS6+p2k7wElBkdizlOkw==\r
+X-Received: by 10.194.83.134 with SMTP id q6mr19025171wjy.131.1457873384094;\r
+ Sun, 13 Mar 2016 05:49:44 -0700 (PDT)\r
+Received: from localhost (mobile-access-bcee39-255.dhcp.inet.fi.\r
+ [188.238.57.255])\r
+ by smtp.gmail.com with ESMTPSA id v2sm11433321wmd.24.2016.03.13.05.49.43\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Sun, 13 Mar 2016 05:49:43 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Edward Betts <edward@4angle.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Don't bother checking for mbox files\r
+In-Reply-To: <20160313105742.GA9173@4angle.com>\r
+References: <86io0v9oum.fsf@hiro.keithp.com>\r
+ <20160313105742.GA9173@4angle.com>\r
+User-Agent: Notmuch/0.21+74~g711eac8 (http://notmuchmail.org) Emacs/24.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 13 Mar 2016 14:48:41 +0200\r
+Message-ID: <87mvq2pmqe.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 Mar 2016 12:49:47 -0000\r
+\r
+On Sun, 13 Mar 2016, Edward Betts <edward@4angle.com> wrote:\r
+> Keith Packard <keithp@keithp.com> wrote:\r
+>> Postfix adds mbox-style From lines when used in combination with\r
+>> maildrop or .forward files. If they have another line starting with\r
+>> 'From ' in them, notmuch complains about them not being mail files.\r
+>> \r
+>> If we assume the user hasn't screwed up and misconfigured their mail\r
+>> system, then we can safely ignore whether the file started with an\r
+>> mbox header and just parse it as a single-message file.\r
+>\r
+> I think it is fine to go ahead with this change. At the same time the\r
+> behaviour of Postfix should be corrected so it doesn't add mbox-style From\r
+> lines to mails in maildir format.\r
+\r
+I disagree with making the change (as-is, at least).\r
+\r
+In general, Notmuch does not support mboxes. We expect maildir style one\r
+message per file mail storage. We support single-message mboxes as a\r
+special case, in part because, as you note, there's plenty of other\r
+software that adds the mbox "From " line even though delivering to\r
+maildir.\r
+\r
+I think it's misleading and confusing to the users to accept and index\r
+the first message of mboxes, and silently ignore the rest (or worse,\r
+index all of the mbox and associate the text with the first message). I\r
+think we should reject multi-message mboxes, because we have no code to\r
+handle them. This patch throws away that check.\r
+\r
+Now, IIUC, the problem here is not that the files actually are\r
+multi-message mboxes. We could use a sample message (even a crafted one)\r
+that exhibits the problem, so we could add a test case, and fix Notmuch\r
+to deal with it gracefully (if we decide catering to potentially broken\r
+other software is the way to go), while retaining the code to reject\r
+multi-message mboxes. With the test case, we'd also avoid accidentally\r
+breaking this in the future.\r
+\r
+BR,\r
+Jani.\r