Re: [PATCH] go: use a different goconfig package

diff --git a/8c/90e91e0ae9244c91e5c02c0c5d31436ee36c47 b/8c/90e91e0ae9244c91e5c02c0c5d31436ee36c47
new file mode 100644 (file)
index 0000000..e6a7839
--- /dev/null
+++ b/8c/90e91e0ae9244c91e5c02c0c5d31436ee36c47
@@ -0,0 +1,109 @@
+Return-Path: <teythoon@jade-hamburg.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 38A0C431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Apr 2013 02:42:19 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id vnmOE3wvtIL3 for <notmuch@notmuchmail.org>;\r
+       Wed, 24 Apr 2013 02:42:18 -0700 (PDT)\r
+Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 5F155431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Apr 2013 02:42:18 -0700 (PDT)\r
+Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by mail.cryptobitch.de (Postfix) with ESMTPSA id 57D8E605F2B\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Apr 2013 11:42:09 +0200 (CEST)\r
+Received: by mail.jade-hamburg.de (Postfix, from userid 401)\r
+       id B2F08DF2A5; Wed, 24 Apr 2013 11:42:08 +0200 (CEST)\r
+Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de\r
+ [10.1.1.109]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))     (No\r
+ client certificate requested) (Authenticated sender: teythoon)        by\r
+ mail.jade-hamburg.de (Postfix) with ESMTPSA id A96DDDF29F;    Wed, 24 Apr 2013\r
+ 11:42:06 +0200 (CEST)\r
+Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.80)\r
+       (envelope-from <teythoon@thinkbox.jade-hamburg.de>)\r
+       id 1UUwCE-00073a-Uh; Wed, 24 Apr 2013 11:41:02 +0200\r
+Content-Type: text/plain; charset="utf-8"\r
+MIME-Version: 1.0\r
+Content-Transfer-Encoding: quoted-printable\r
+From: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+User-Agent: alot/0.3.3+\r
+To: David Bremner <david@tethera.net>,  notmuch@notmuchmail.org\r
+References:\r
+ <1366729987-16925-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <87d2tkoo80.fsf@zancas.localnet>\r
+In-Reply-To: <87d2tkoo80.fsf@zancas.localnet>\r
+Message-ID: <20130424094102.7753.16880@thinkbox.jade-hamburg.de>\r
+Subject: Re: [PATCH] go: use a different goconfig package\r
+Date: Wed, 24 Apr 2013 11:41:02 +0200\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 24 Apr 2013 09:42:19 -0000\r
+\r
+Quoting David Bremner (2013-04-24 00:51:11)\r
+> Justus Winter <4winter@informatik.uni-hamburg.de> writes:\r
+> =\r
+\r
+> > The notmuch-addrlookup utility uses a third party library to read the\r
+> > notmuch configuration file. The previously used implementation at\r
+> > "github.com/kless/goconfig" vanished, so this patch switches to the\r
+> > implementation at "github.com/msbranco/goconfig". As the\r
+> > implementations differ at the API level, the code is updated\r
+> > accordingly.\r
+> =\r
+\r
+> It's great that you fixed this, but the whole idea of something failing\r
+> to build depending on the status of a website makes me pretty\r
+> uncomfortable.\r
+> =\r
+\r
+> d\r
+\r
+Ah, I pondered whether I should write more about the lib change. Maybe\r
+I should have.\r
+\r
+So there are two libs, kless and msbranco for short. kless is a fork\r
+of msbranco, and it seems like the author abandoned his fork. So we\r
+are now using the original lib, msbranco. msbranco seems to be in\r
+"maintenance" mode, but has recently received updates to fix some\r
+minor issues wrt. go 1.1. There are a lot of forks of msbranco on\r
+github, so even if msbranco vanishes as well, we can pick the next\r
+most promising fork.\r
+\r
+So yeah, I feel the same way, it's unfortunately that I had to patch\r
+this, but we're better of now (it builds again and we moved to a more\r
+"vanilla" goconfig API (assuming the other forks do not change the api\r
+as much as kless did)).\r
+\r
+And I think you are being a bit harsh with the "status of the website"\r
+comment. In case you are not familiar with go,\r
+"github.com/kless/goconfig" is a package path, not a website. It just\r
+happens to also be the host+resource part of a URL that points to the\r
+github project page. So what happened here is that the VCS repository\r
+specified by the package path vanished, not some web site (well, that\r
+vanished too, but that didn't cause the build failure). If you happen\r
+to have golang installed, type "go help remote" for more information.\r
+\r
+Cheers,\r
+Justus\r