--- /dev/null
+Return-Path: <dme@dme.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 1C1CE431FBD\r
+ for <notmuch@notmuchmail.org>; Tue, 13 May 2014 03:02:15 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id s+LVSQHiwBMh for <notmuch@notmuchmail.org>;\r
+ Tue, 13 May 2014 03:02:07 -0700 (PDT)\r
+Received: from mail-we0-f169.google.com (mail-we0-f169.google.com\r
+ [74.125.82.169]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 39E19431FAF\r
+ for <notmuch@notmuchmail.org>; Tue, 13 May 2014 03:02:07 -0700 (PDT)\r
+Received: by mail-we0-f169.google.com with SMTP id u56so119807wes.28\r
+ for <notmuch@notmuchmail.org>; Tue, 13 May 2014 03:02:06 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:to:subject:in-reply-to:references:user-agent\r
+ :from:date:message-id:mime-version:content-type;\r
+ bh=3DThrqgYVORoc4xFdqPog6dPgYfLOJewrgMnGXddAUo=;\r
+ b=Hdz3YMnugQdkJWid4gDTKz//pIs7bfuIjPm2c9+69TeQ24Wy1zUimnxAOSwc7X/FQV\r
+ mYeGfdZECgvCDCdhPojNw/zZTp+0cCOgEB1Xj76eEmZ7Dc0wgUzKDxc7tfPHiRODXe9v\r
+ eOjriNMXFs2kK4YqDqMWHf4h0M+kmU3DDOJmwoDpD/hpoRSrtYdhgn7akOLoyjCeNUgA\r
+ fL2Gd7UB29913c9rJaBKfD2uSZ895MkP+FVSmz9fnQqxT25Gcly+vQuYEv9oo67ZRhfG\r
+ OaeEvH/nUEjTDZx6icH5yPkyzEljGxl13rcNgOfHMY9IPKogl5I2q4ydbDJN3XLWgPlh\r
+ eEYQ==\r
+X-Gm-Message-State:\r
+ ALoCoQnGy1YTqKSAb1nHsNHODpOvB+shFxpNTJ9n/nJm9jEXdR8QZbvpiq2mceT+JzMXdSFjqhsA\r
+X-Received: by 10.180.99.40 with SMTP id en8mr20470196wib.24.1399975324912;\r
+ Tue, 13 May 2014 03:02:04 -0700 (PDT)\r
+Received: from localhost ([2a01:348:1a2:1:a288:b4ff:fe8a:77d8])\r
+ by mx.google.com with ESMTPSA id\r
+ mw4sm21035587wib.12.2014.05.13.03.02.02 for <multiple recipients>\r
+ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Tue, 13 May 2014 03:02:03 -0700 (PDT)\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 0/9] emacs: Improve the cited message included in\r
+ replies\r
+In-Reply-To: <87vbtak5uz.fsf@qmul.ac.uk>\r
+References: <87sixdujkv.fsf@qmul.ac.uk>\r
+ <1399897769-26809-1-git-send-email-dme@dme.org>\r
+ <87vbtak5uz.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-pc-linux-gnu)\r
+From: David Edmondson <dme@dme.org>\r
+Date: Tue, 13 May 2014 11:01:58 +0100\r
+Message-ID: <cunvbta5755.fsf@hotblack-desiato.hh.sledj.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+ micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 13 May 2014 10:02:15 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+Firstly, I don't think that the code resulting from this patch series is\r
+beyond improvement - the intention was really only that it be better\r
+than the current implementation.\r
+\r
+On Mon, May 12 2014, Mark Walters wrote:\r
+> On Mon, 12 May 2014, David Edmondson <dme@dme.org> wrote:\r
+>> emacs: Improve the cited message included in replies\r
+>>\r
+>> I tried to do things in small increments to make it easier to review.\r
+>>\r
+>> v2:\r
+>> - Don't run the text/plain hooks when generating the message to quote.\r
+>>\r
+>> v3:\r
+>> - Remove the 'no-button code, as it's no longer used.\r
+>> - Control the insertion of part headers using a function.\r
+>> - Fix the tests.\r
+>\r
+> I think I broadly like this series. I haven't thought through all the\r
+> ramifications yet so this is just some first thoughts. I will also send\r
+> some comments on individual patches.\r
+\r
+Thanks!\r
+\r
+> In notmuch-show we go to notmuch-show-insert-part-*/* to\r
+> notmuch-mm-display-part-inline and then leave the decision to inline to\r
+> mm-inlined-types. I think this means that, by default, we will not\r
+> inline signatures amongst other things.\r
+\r
+The rule is essentially: whatever text would be shown when the message\r
+is displayed for reading, without any of the washing.\r
+\r
+> So at the least I think we should decide whether we want to override\r
+> mm-inlined-types.\r
+\r
+I'm not really clear on the benefits of this. Could you explain?\r
+\r
+> Alternatively, and in my view preferably, we could have a function or\r
+> variable of our own which says which parts to include. Indeed, if do\r
+> it with a function we might be able to make an option to reply to mean\r
+> "include parts currently shown in the notmuch-show buffer" which might\r
+> be nice.\r
+\r
+That seems over complicated to me. The rule (above) from this series\r
+is easy to understand and work with. Other mechanisms could be\r
+implemented later, of course.\r
+\r
+> There is a related question and possible bug that we might be able to\r
+> do something about at the same time: should we include text parts in the\r
+> reply if they have content-disposition attachment? I have been caught\r
+> about by this on one occasion replying to a message with a 500K log file\r
+> attached (and notmuch-show/wash becomes very slow with a 500K\r
+> message!)\r
+\r
+This is really a question of what happens in `show' mode. If it is\r
+currently displaying text parts with content-disposition attachment,\r
+that sounds like a bug that should be fixed (which would mean that the\r
+cited message wouldn't include that part either).\r
+\r
+> Finally, I am not sure whether I like having buttons in the reply. My\r
+> instinct is against, but they do add context.\r
+\r
+The last patch in the series is an example of trying to do the right\r
+thing - show the part headers when they are necessary for proper\r
+understanding, but elide them in all other cases.\r
+\r
+The mechanism used to do this is pretty crude in the patch. One could\r
+imagine a better implementation that examines the depth of the part\r
+tree, etc.\r
+\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+>\r
+>\r
+>>\r
+>>\r
+>> David Edmondson (9):\r
+>> emacs/show: Re-arrange determination if a part header is necessary\r
+>> emacs/show: Allow the user to decide when part headers should be\r
+>> inserted\r
+>> emacs/show: Accommodate the lack of part header buttons\r
+>> emacs/mua: Generate improved cited text for replies\r
+>> emacs/show: Remove the 'no-buttons option of\r
+>> `notmuch-show-insert-bodypart'\r
+>> emacs/mua: Don't insert part headers in citations\r
+>> test: Update the test output to accord with the reply changes\r
+>> emacs/mua: Insert part headers depending on the message\r
+>> test: Update the test output to accord with more reply changes\r
+>>\r
+>> emacs/notmuch-mua.el | 82 +++++++++++++++++++-----------\r
+>> emacs/notmuch-show.el | 135 +++++++++++++++++++++++++++++++------------=\r
+-------\r
+>> test/T310-emacs.sh | 44 ++++++++++++++++\r
+>> 3 files changed, 180 insertions(+), 81 deletions(-)\r
+>>\r
+>> --=20\r
+>> 2.0.0.rc0\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature; name="signature.asc"\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1\r
+\r
+iKYEARECAGYFAlNx7ZZfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl\r
+bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5\r
+RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRYq8QCeOUu0kzUhaHypeKMf94pxt/7+\r
+aacAoIyc1cHTTjq2CoeLeIs8WUqH9ok7\r
+=Xbt6\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r
projects / notmuch-archives.git / commitdiff