Re: [PATCH] emacs: push mark before signature on reply

diff --git a/1e/a1f8a988baa6433f7fcfe9357cf927feefa404 b/1e/a1f8a988baa6433f7fcfe9357cf927feefa404
new file mode 100644 (file)
index 0000000..9c0f14b
--- /dev/null
+++ b/1e/a1f8a988baa6433f7fcfe9357cf927feefa404
@@ -0,0 +1,113 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 24E36431FBD\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Mar 2014 00:04:07 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id dxDi2anXo5dt for <notmuch@notmuchmail.org>;\r
+       Sun, 30 Mar 2014 00:03:59 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 55872431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Mar 2014 00:03:59 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1WU9mY-0000Wh-E9; Sun, 30 Mar 2014 08:03:54 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1WU9mY-0001fJ-4m; Sun, 30 Mar 2014 08:03:50 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: push mark before signature on reply\r
+In-Reply-To: <1396029865-23133-1-git-send-email-jani@nikula.org>\r
+References: <1396029865-23133-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 30 Mar 2014 08:03:49 +0100\r
+Message-ID: <878ursqiay.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-Geographic: According to ripencc,\r
+       this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: d8cb88f468d37a763dbf8bd63a298f99 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.0 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 30 Mar 2014 07:04:07 -0000\r
+\r
+\r
+LGTM +1\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+On Fri, 28 Mar 2014, Jani Nikula <jani@nikula.org> wrote:\r
+> We push mark on reply so user can cut the quote. Push the mark before\r
+> signature, if any, instead of end of buffer so the signature is\r
+> preserved.\r
+>\r
+> This is consistent with message-kill-to-signature.\r
+> ---\r
+>  emacs/notmuch-mua.el | 6 +++++-\r
+>  1 file changed, 5 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el\r
+> index b16a10ecd379..ba3ef275ec5e 100644\r
+> --- a/emacs/notmuch-mua.el\r
+> +++ b/emacs/notmuch-mua.el\r
+> @@ -226,8 +226,12 @@ list."\r
+>      ;; Quote the original message according to the user's configured style.\r
+>      (message-cite-original))))\r
+>  \r
+> -  (goto-char (point-max))\r
+> +  ;; Push mark right before signature, if any.\r
+> +  (message-goto-signature)\r
+> +  (unless (eobp)\r
+> +    (end-of-line -1))\r
+>    (push-mark)\r
+> +\r
+>    (message-goto-body)\r
+>    (set-buffer-modified-p nil))\r
+>  \r
+> -- \r
+> 1.9.0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
+\r