Re: [PATCH v3 2/2] search: Support automatic tag exclusions

diff --git a/81/4696f1574bea184bd7066a08db4346e535b391 b/81/4696f1574bea184bd7066a08db4346e535b391
new file mode 100644 (file)
index 0000000..852e127
--- /dev/null
+++ b/81/4696f1574bea184bd7066a08db4346e535b391
@@ -0,0 +1,135 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0E681431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 13:23:21 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5t-uxJdMgX1u for <notmuch@notmuchmail.org>;\r
+       Thu, 19 Jan 2012 13:23:20 -0800 (PST)\r
+Received: from mail-we0-f181.google.com (mail-we0-f181.google.com\r
+       [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 4C78A431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 13:23:20 -0800 (PST)\r
+Received: by werp13 with SMTP id p13so386490wer.26\r
+       for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 13:23:19 -0800 (PST)\r
+Received: by 10.180.76.235 with SMTP id n11mr42054342wiw.11.1327008199106;\r
+       Thu, 19 Jan 2012 13:23:19 -0800 (PST)\r
+Received: from localhost ([109.131.97.13])\r
+       by mx.google.com with ESMTPS id eb2sm30216787wib.0.2012.01.19.13.23.18\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Thu, 19 Jan 2012 13:23:18 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH v3 2/2] search: Support automatic tag exclusions\r
+In-Reply-To: <20120119193647.GN16740@mit.edu>\r
+References: <1326586654-16840-3-git-send-email-amdragon@mit.edu>\r
+       <1327000744-25463-1-git-send-email-pieter@praet.org>\r
+       <20120119193647.GN16740@mit.edu>\r
+User-Agent: Notmuch/0.11+99~gab86e73 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Thu, 19 Jan 2012 22:21:28 +0100\r
+Message-ID: <8739bbo0br.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 19 Jan 2012 21:23:21 -0000\r
+\r
+On Thu, 19 Jan 2012 14:36:47 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Quoth Pieter Praet on Jan 19 at  8:19 pm:\r
+> > Nice feature!  I won't be using it myself, but I can imagine it being\r
+> > *very* useful for those who still feel the need to "delete" email :).\r
+> \r
+> Same here.  I probably will use the spam tag, though.\r
+> \r
+\r
+Really?  Then how will you be able to reply to my emails?!?  ;)\r
+\r
+\r
+> > Nitpicking:\r
+> > \r
+> > - All other config-related functions and args include the section title\r
+> >   in their name [1], so for the sake of consistency, we might want to\r
+> >   mirror that.  Also, the "auto"matic part is pretty much a given.\r
+> > \r
+> >   So I'd like to suggest replacing all occurences of "auto_exclude_tags"\r
+> >   with "search_exclude_tags" (and simply "exclude_tags" in the args to\r
+> >   `_config_get_list' and `_config_set_list', of course).\r
+> \r
+> You are technically correct, the best kind of correct.  I'd completely\r
+> missed this pattern.  This should get fixed ASAP, while this feature\r
+> still has limited adoption.\r
+> \r
+> >   Unfortunately, this would also partially invalidate your recent NEWS\r
+> >   submission [2].\r
+> \r
+> No worries, though maybe you want to tack an updated version of that\r
+> patch on the end of your series?\r
+> \r
+\r
+Will do.\r
+\r
+\r
+> > - If the 'search.exclude_tags' option is missing from the config file,\r
+> >   its value is automatically set to "deleted;spam;", which probably isn't\r
+> >   a sane default.  Luckily, you've already provided the solution [3].\r
+> \r
+> I'm good either way.  I got lost in the discussion of defaults but\r
+> Jamie assured me everything was okay, so I took the path of least\r
+> resistance and left things as they were.\r
+> \r
+\r
+Hmm.  I probably haven't read everything pertaining to that issue yet,\r
+but IMO it violates the Principle of Least Surprise with a vengeance.\r
+\r
+Tagging stuff some way or another shouldn't make it disappear by default.\r
+\r
+What if "spam" means "read it when you're bored", or "deleted" means\r
+"processed request for user deletion" (pretty far-fetched, but still...)\r
+for someone?\r
+\r
+\r
+> > - To make new users aware of the config option's existence, we should\r
+> >   prompt them to configure it during setup.\r
+> \r
+> Sure.\r
+> \r
+> > Patches follow.\r
+> > \r
+> > \r
+> > Peace\r
+> > \r
+> > \r
+> > [1] Eg. `notmuch_config_get_user_name', `notmuch_config_get_new_tags',\r
+> >         `notmuch_config_get_maildir_synchronize_flags', ...\r
+> > \r
+> > [2] id:"1326920330-31496-1-git-send-email-amdragon@mit.edu"\r
+> > \r
+> > [3] id:"20120117203211.GQ16740@mit.edu"\r
+> > \r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r